Skip to content

chore: Only use master test runs for status badge - #3475

Merged
gmlewis merged 1 commit into
google:masterfrom
iCiaran:tests-badge-master
Feb 11, 2025
Merged

chore: Only use master test runs for status badge#3475
gmlewis merged 1 commit into
google:masterfrom
iCiaran:tests-badge-master

Conversation

@iCiaran

Copy link
Copy Markdown
Contributor

Before this change the most recent run from any branch was used for the badge, which could have been a failed run on a branch (for example earlier today the most recent run was https://github.com/google/go-github/actions/runs/13250097376/job/36985764795 and the readme showed the test status as failing).

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iCiaran !
LGTM
Merging.

@codecov

codecovBot commented Feb 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (26f71a3) to head (6a762c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3475 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15538 15538 =======================================
Hits 14145 14145 Misses 1221 1221 Partials 172 172 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
gmlewis merged commit ce42642 into google:masterFeb 11, 2025
@iCiaran
iCiaran deleted the tests-badge-master branch February 12, 2025 09:02
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@iCiaran@gmlewis