Skip to content

Document upcoming changes to events payload - #3667

Merged
gmlewis merged 2 commits into
google:masterfrom
roman-y-wu:master
Aug 12, 2025
Merged

Document upcoming changes to events payload#3667
gmlewis merged 2 commits into
google:masterfrom
roman-y-wu:master

Conversation

@roman-y-wu

@roman-y-wuroman-y-wu commented Aug 11, 2025

Copy link
Copy Markdown

Closes#3665

Roman Wu added 2 commits August 11, 2025 17:04
feat: Add deprecation notices for AuthorAssociation field in various event types
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (84a0945) to head (2640f20).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3667 +/- ##
=======================================
Coverage 91.23% 91.23% =======================================
Files 185 185 Lines 16421 16421 =======================================
Hits 14982 14982 Misses 1254 1254 Partials 185 185 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis changed the title Upcoming changes to events payload (Issue #3665)Document upcoming changes to events payload (Issue #3665)Aug 12, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @romanywu!
LGTM.

Awaiting second LGTM+Approval from any other contributor before merging.

@alexandear or @stevehipwell - might one of you be available for a code review? Thank you!

@alexandearalexandear left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove (Issue #3665) from PR's title and add Closes #3665 to description.

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanywu this looks really good, just waiting on the PR changes @alexandear asked for before I approve.

@gmlewis if you want to get this merged you should be able to update the title and PR body.

@roman-y-wuroman-y-wu changed the title Document upcoming changes to events payload (Issue #3665)Document upcoming changes to events payloadAug 12, 2025
@roman-y-wu

Copy link
Copy Markdown
Author

Please remove (Issue #3665) from PR's title and add Closes #3665 to description.

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @romanywu, @alexandear, and @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit 2eec208 into google:masterAug 12, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upcoming changes to events payload

4 participants

@roman-y-wu@gmlewis@alexandear@stevehipwell