Skip to content

feat: Add secret scanning push protection pattern configurations API - #3672

Merged
gmlewis merged 12 commits into
google:masterfrom
dmclink:secret-scanning-pattern-configs
Aug 13, 2025
Merged

feat: Add secret scanning push protection pattern configurations API#3672
gmlewis merged 12 commits into
google:masterfrom
dmclink:secret-scanning-pattern-configs

Conversation

@dmclink

@dmclinkdmclink commented Aug 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds support for newly announced API endpoints

Closes#3661

@alexandear

alexandear commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Please see #3667 (review)

@dmclinkdmclink changed the title feat: Add secret scanning push protection pattern configurations API (Issue #3661)feat: Add secret scanning push protection pattern configurations API [Closes #3661]Aug 12, 2025
@dmclinkdmclink changed the title feat: Add secret scanning push protection pattern configurations API [Closes #3661]feat: Add secret scanning push protection pattern configurations APIAug 12, 2025
@codecov

codecovBot commented Aug 12, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.02%. Comparing base (84a0945) to head (35a09e2).
⚠️ Report is 6 commits behind head on master.

Files with missing linesPatch %Lines
github/secret_scanning_pattern_configs.go25.00%39 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3672 +/- ##
==========================================
- Coverage 91.23% 91.02% -0.21% 
==========================================
Files 185 186 +1 Lines 16421 16473 +52 ==========================================
+ Hits 14982 14995 +13 - Misses 1254 1293 +39 
Partials 185 185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 12, 2025
gmlewis
gmlewis requested changes Aug 12, 2025
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dmclink!
Just a couple additions, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/secret_scanning_pattern_configs.go
CustomPatternSettings []*SecretScanningCustomPatternSetting `json:"custom_pattern_settings,omitempty"`
}

type SecretScanningProviderPatternSetting struct {

@gmlewisgmlewisAug 12, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a godoc-style comment for every exported struct.

Comment threadgithub/secret_scanning_pattern_configs.go
gmlewis
gmlewis approved these changes Aug 12, 2025
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dmclink!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@alexandear or @stevehipwell - might one of you have time for a code review? Thank you!

stevehipwell
stevehipwell approved these changes Aug 13, 2025
View reviewed changes

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 13, 2025
@gmlewis

gmlewis commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit b0d4e1e into google:masterAug 13, 2025
5 of 7 checks passed
@gmlewisgmlewis mentioned this pull request Sep 22, 2025
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat: Add secret scanning push protection pattern configurations API (g…
1678447
…oogle#3672)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@stevehipwellstevehipwellstevehipwell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for new push protection APIs

4 participants

@dmclink@alexandear@gmlewis@stevehipwell