Skip to content

Add type RepositoryAttachment for GetRepositoriesForCodeSecurityConfiguration - #3705

Closed
ericmortebidbax wants to merge 1 commit into
google:masterfrom
ericmortebidbax:fix-3217-json-unmarshal-array-error
Closed

Add type RepositoryAttachment for GetRepositoriesForCodeSecurityConfiguration#3705
ericmortebidbax wants to merge 1 commit into
google:masterfrom
ericmortebidbax:fix-3217-json-unmarshal-array-error

Conversation

@ericmortebidbax

Copy link
Copy Markdown

As mentioned in my comment under #3217 there is a problem with the way GetRepositoriesForCodeSecurityConfiguration unmarshales the API result data. This PR fixes that particular problem.

It does not necessarily fix the original issue as reported.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ericmort

Copy link
Copy Markdown
Contributor

This is a duplicate of #3707, this PR should be closed.

@gmlewis

Copy link
Copy Markdown
Collaborator

This is a duplicate of #3707, this PR should be closed.

OK, thank you, @ericmort!
Unfortunately, I can't close it yet but will hopefully get write access to this repo soon.

@codecov

codecovBot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.08%. Comparing base (f137c94) to head (f3c6809).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3705 +/- ##
=======================================
Coverage 91.08% 91.08% =======================================
Files 187 187 Lines 16581 16581 =======================================
Hits 15103 15103 Misses 1293 1293 Partials 185 185 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

Copy link
Copy Markdown
Collaborator

This is a duplicate of #3707, this PR should be closed.

Closing.

@gmlewisgmlewis closed this Sep 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ericmortebidbax@ericmort@gmlewis