Skip to content

fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration - #3707

Merged
gmlewis merged 4 commits into
google:masterfrom
ericmort:fix-json-unmarshal-error
Sep 25, 2025
Merged

fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration#3707
gmlewis merged 4 commits into
google:masterfrom
ericmort:fix-json-unmarshal-error

Conversation

@ericmort

@ericmortericmort commented Aug 30, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: GetRepositoriesForCodeSecurityConfiguration now returns RepositoryAttachment instead of Repository.

Adds type RepositoryAttachment for GetRepositoriesForCodeSecurityConfiguration

Fixes unmarshal error in GetRepositoriesForCodeSecurityConfiguration, as described in #3217.

(I submitted the PR under my corporate GitHub user, but I could not get a proper google/CLA so using my personal user.)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ericmort!
LGTM.

Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).

NOTES TO SELF:

  • Add to the description:
    BREAKING CHANGE: GetRepositoriesForCodeSecurityConfiguration now returns RepositoryAttachment instead of Repository.
  • Add Breaking API label
  • Change PR title:
    fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration

@gmlewis

Copy link
Copy Markdown
Collaborator

Fixes: #3217.

@codecov

codecovBot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (9febb45) to head (ecee97a).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3707 +/- ##
=======================================
Coverage 91.11% 91.11% =======================================
Files 187 187 Lines 16684 16686 +2 =======================================
+ Hits 15202 15204 +2 
Misses 1295 1295 Partials 187 187 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 22, 2025
@gmlewisgmlewis changed the title fix #3217 unmarshal errorfix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfigurationSep 22, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

@ericmort - would you mind resolving the conflicts in this PR or would you like me to do that?

@ericmort

Copy link
Copy Markdown
ContributorAuthor

@gmlewis I resolved it now

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis I resolved it now

@ericmort - could you please investigate the lint and test failures?

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @ericmort!

cc: @stevehipwell

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 25, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit 30fb0c6 into google:masterSep 25, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ericmort@gmlewis@stevehipwell