Uh oh!
There was an error while loading. Please reload this page.
fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration - #3707
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ericmort!
LGTM.
Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).
NOTES TO SELF:
- Add to the description:
BREAKING CHANGE:GetRepositoriesForCodeSecurityConfigurationnow returnsRepositoryAttachmentinstead ofRepository. - Add Breaking API label
- Change PR title:
fix!: ReturnRepositoryAttachmentfromGetRepositoriesForCodeSecurityConfiguration
gmlewis
commented
Sep 18, 2025
Fixes: #3217. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3707 +/- ##
=======================================
Coverage 91.11% 91.11% =======================================
Files 187 187 Lines 16684 16686 +2 =======================================
+ Hits 15202 15204 +2
Misses 1295 1295 Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RepositoryAttachment from GetRepositoriesForCodeSecurityConfigurationgmlewis
commented
Sep 22, 2025
@ericmort - would you mind resolving the conflicts in this PR or would you like me to do that? |
ericmort
commented
Sep 23, 2025
@gmlewis I resolved it now |
gmlewis
commented
Sep 23, 2025
gmlewis
commented
Sep 23, 2025
Thank you, @ericmort! cc: @stevehipwell |
gmlewis
commented
Sep 25, 2025
Thank you, @stevehipwell! |
Uh oh!
There was an error while loading. Please reload this page.
BREAKING CHANGE: GetRepositoriesForCodeSecurityConfiguration now returns RepositoryAttachment instead of Repository.
Adds type RepositoryAttachment for GetRepositoriesForCodeSecurityConfiguration
Fixes unmarshal error in GetRepositoriesForCodeSecurityConfiguration, as described in #3217.
(I submitted the PR under my corporate GitHub user, but I could not get a proper google/CLA so using my personal user.)