Skip to content

feat!: Add enterprise security configurations, update API fields - #3812

Merged
gmlewis merged 8 commits into
google:masterfrom
tim-goto:master
Nov 13, 2025
Merged

feat!: Add enterprise security configurations, update API fields#3812
gmlewis merged 8 commits into
google:masterfrom
tim-goto:master

Conversation

@tim-goto

@tim-gototim-goto commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGES: Several OrganizationsService methods have been renamed for better consistency.

please let me know if I should drop the commit with breaking changes and what you think about the other commits

@google-cla

google-claBot commented Nov 7, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title feat: add enterprise security configurations, update api fieldsfeat: Add enterprise security configurations, update API fieldsNov 7, 2025
@tim-goto

Copy link
Copy Markdown
ContributorAuthor

sorry forgot to add the generated files after my latest change..

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 7, 2025
@codecov

codecovBot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (8760289) to head (3a08aad).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3812 +/- ##
==========================================
+ Coverage 92.27% 92.38% +0.10% 
==========================================
Files 192 195 +3 Lines 13896 14094 +198 ==========================================
+ Hits 12823 13021 +198 
Misses 884 884 Partials 189 189 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis changed the title feat: Add enterprise security configurations, update API fieldsfeat!: Add enterprise security configurations, update API fieldsNov 7, 2025
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Nov 7, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please let me know if I should drop the commit with breaking changes and what you think about the other commits

I think that is fine, thanks. Please address the few minor suggestions I've made, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go
Comment threadgithub/enterprise_codesecurity_configurations.go
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
@tim-goto

Copy link
Copy Markdown
ContributorAuthor

I tried to address all comments, please let me know if there is anything else I should do.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tim-goto!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear - as you already gave feedback.

Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
@tim-goto

Copy link
Copy Markdown
ContributorAuthor

thanks a lot for the very thorough review.

Comment threadgithub/enterprise_codesecurity_configurations.go Outdated
Comment threadgithub/orgs_codesecurity_configurations.go Outdated
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 13, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @alexandear!
Merging.

@gmlewis
gmlewis merged commit 81f066c into google:masterNov 13, 2025
7 checks passed
@tim-goto

Copy link
Copy Markdown
ContributorAuthor

thanks a lot for merging my PR, would you mind creating a new release?

@gmlewis

Copy link
Copy Markdown
Collaborator

thanks a lot for merging my PR, would you mind creating a new release?

Yes, #3814 is close to merging, and I'll cut a release after that one is merged.

@gmlewis

Copy link
Copy Markdown
Collaborator

This is now available here:
https://github.com/google/go-github/releases/tag/v79.0.0

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…gle#3812)
BREAKING CHANGES: Several `OrganizationsService` methods have been renamed for better consistency.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tim-goto@gmlewis@alexandear