Uh oh!
There was an error while loading. Please reload this page.
feat!: Add enterprise security configurations, update API fields - #3812
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tim-goto
commented
Nov 7, 2025
sorry forgot to add the generated files after my latest change.. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3812 +/- ##
==========================================
+ Coverage 92.27% 92.38% +0.10%
==========================================
Files 192 195 +3 Lines 13896 14094 +198 ==========================================
+ Hits 12823 13021 +198
Misses 884 884 Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
please let me know if I should drop the commit with breaking changes and what you think about the other commits
I think that is fine, thanks. Please address the few minor suggestions I've made, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ions, rename get to list
tim-goto
commented
Nov 11, 2025
I tried to address all comments, please let me know if there is anything else I should do. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tim-goto!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @alexandear - as you already gave feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tim-goto
commented
Nov 13, 2025
thanks a lot for the very thorough review. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
commented
Nov 13, 2025
Thank you, @alexandear! |
Uh oh!
There was an error while loading. Please reload this page.
tim-goto
commented
Nov 14, 2025
thanks a lot for merging my PR, would you mind creating a new release? |
gmlewis
commented
Nov 14, 2025
Yes, #3814 is close to merging, and I'll cut a release after that one is merged. |
gmlewis
commented
Nov 14, 2025
This is now available here: |
…gle#3812) BREAKING CHANGES: Several `OrganizationsService` methods have been renamed for better consistency.
BREAKING CHANGES: Several
OrganizationsServicemethods have been renamed for better consistency.please let me know if I should drop the commit with breaking changes and what you think about the other commits