Skip to content

feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroups - #3814

Merged
gmlewis merged 26 commits into
google:masterfrom
elminster-aom:enterpriseSCIM
Nov 14, 2025
Merged

feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroups#3814
gmlewis merged 26 commits into
google:masterfrom
elminster-aom:enterpriseSCIM

Conversation

@elminster-aom

@elminster-aomelminster-aom commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: SCIMService.ListSCIMProvisionedGroupsForEnterprise is now EnterpriseService.ListProvisionedSCIMEnterpriseGroups.

Fixes: #3813

Summary

From API Docs https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim, implement:

  • GET /scim/v2/enterprises/{enterprise}/Groups

Breaking Change

The SCIMService.ListSCIMProvisionedGroupsForEnterprise method has been moved to EnterpriseService.ListProvisionedSCIMGroups.

@elminster-aomelminster-aom changed the title Implement Enterprise SCIMImplement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroupsForEnterpriseNov 10, 2025
@codecov

codecovBot commented Nov 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (d69610a) to head (7368118).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3814 +/- ##
=======================================
Coverage 92.38% 92.38% =======================================
Files 195 196 +1 Lines 14094 14094 =======================================
Hits 13021 13021 Misses 884 884 Partials 189 189 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elminster-aom
elminster-aom marked this pull request as ready for review November 12, 2025 16:58
@elminster-aomelminster-aom mentioned this pull request Nov 12, 2025
12 tasks
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Nov 12, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elminster-aom!
Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

Comment threadgithub/enterprise_scim.go Outdated
Comment threadgithub/enterprise_scim.go Outdated
Comment threadgithub/enterprise_scim.go Outdated
Comment threadgithub/enterprise_scim.go Outdated
Comment threadgithub/enterprise_scim.go
Comment threadgithub/enterprise_scim.go Outdated
@elminster-aom

Copy link
Copy Markdown
ContributorAuthor

Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

@gmlewis, I couldn't find the PR you mention but I think the word "Enterprise" should appear somehow (Maybe with just an "E"? Suggestions are welcome) otherwise it may get confusing with the other SCIM resources in /github/scim.go.

@elminster-aomelminster-aom changed the title Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroupsForEnterpriseImplement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroupsNov 13, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

@gmlewis, I couldn't find the PR you mention but I think the word "Enterprise" should appear somehow (Maybe with just an "E"? Suggestions are welcome) otherwise it may get confusing with the other SCIM resources in /github/scim.go.

The idea is that for all our methods, the service must first be specified, like enterpriseService.MethodToCall so we shouldn't need to repeat the ForEnterprise part.

@gmlewisgmlewis changed the title Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroupsfeat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroupsNov 13, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM
Awaiting second LGTM+Approval before merging.

cc: @alexandear

@elminster-aomelminster-aom changed the title feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroupsfeat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroupsNov 13, 2025
Comment threadgithub/enterprise_scim.go
Comment threadgithub/enterprise_scim.go Outdated
Comment threadgithub/enterprise_scim.go
Comment thread.golangci.yml Outdated
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 14, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @elminster-aom and @alexandear!
Merging.

@gmlewis
gmlewis merged commit e53f61e into google:masterNov 14, 2025
7 checks passed
@elminster-aom
elminster-aom deleted the enterpriseSCIM branch November 17, 2025 22:15
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…CIMGroups (google#3814)
BREAKING CHANGE: `SCIMService.ListSCIMProvisionedGroupsForEnterprise` is now `EnterpriseService.ListProvisionedSCIMEnterpriseGroups`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Enterprise SCIM

5 participants

@elminster-aom@gmlewis@alexandear@smazmi@Not-Dhananjay-Mishra