Uh oh!
There was an error while loading. Please reload this page.
Update jsonfieldname linter to support $ in json tag names - #3826
Merged
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
jsonfieldname linter to support $ in json tag namesCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3826 +/- ##
=======================================
Coverage 92.38% 92.38% =======================================
Files 195 195 Lines 14094 14094 =======================================
Hits 13021 13021 Misses 884 884 Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
commented
Nov 13, 2025
CollaboratorAuthor
@stevehipwell - @alexandear - @zyfy29 - do one of you have time for a code review? Thank you! |
alexandear
approved these changes
Nov 14, 2025
stevehipwell
approved these changes
Nov 14, 2025
stevehipwell
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@gmlewis did you check out tagliatelle?
gmlewis
commented
Nov 14, 2025
CollaboratorAuthor
Yes, and found that it wasn't exactly what I wanted. Also, @alexandear independently checked out |
Uh oh!
There was an error while loading. Please reload this page.
jlaportebot added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #3814.