Http implementation by andreamlin · Pull Request #361 · googleapis/gax-java

andreamlin · 2017-08-25T18:09:50Z

Starting implementation for HTTP/JSON.

This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project.

codecov-io · 2017-08-25T18:14:43Z

Codecov Report

Merging #361 into gax-httpjson will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## gax-httpjson #361 +/- ##
===============================================
Coverage 76.65% 76.65% Complexity 494 494 ===============================================
Files 114 114 Lines 2540 2540 Branches 185 185 ===============================================
Hits 1947 1947 Misses 522 522 Partials 71 71

Impacted Files	Coverage Δ	Complexity Δ
...n/java/com/google/api/gax/paging/AbstractPage.java	`71.73% <100%> (ø)`	`11 <1> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74089be...6db8201. Read the comment docs.

… class

…managedhttpjsonchannel

andreamlin · 2017-08-25T19:02:38Z

PTAL

Sign in to view

+ GoogleCredentials defaultCredentials = null;
+ if (googleCredentials == null) {
+ try {
+ defaultCredentials = GoogleCredentials.getApplicationDefault();


Sign in to view

+ responseFuture.set(response);

+ } catch (IOException e) {
+ e.printStackTrace(System.err);


Sign in to view

+ ResponseT response =
+ methodDescriptor.parseResponse(
+ new InputStreamReader(httpResponse.getContent()));
+ responseFuture.set(response);


Sign in to view

+ // Return a map where each entry is the name of a path param mapped to the value of the param.
+ Map<String, String> getPathParams(MessageFormatT apiMessage, Set<String> paramNames);
+
+ // Write out the inner request body of the given message.


Sign in to view

+ PATCH,
+ POST,
+ PUT,
+ TRACE;


Sign in to view

+ * [suffix] is any string; if length greater than 0, it should begin with '/'.
+ * This String format is applied to a serialized ResourceName to create the relative endpoint path.
+ */
+ public abstract String endpointPathTemplate();


Sign in to view

+ Set<String> pathParams,
+ Set<String> queryParams,
+ HttpRequestFormatter httpRequestFormatter,
+ HttpMethod httpMethod) {


Sign in to view

 libraries.jsr305,
 libraries.autovalue,
 libraries.threetenbp,
+ libraries.apiClient,


Sign in to view

+import java.util.Set;
+
+/** Utility class to parse ApiMessages into various HTTP request parts. */
+public class ApiMessageHttpRequestFormatter implements HttpRequestFormatter<ApiMessage> {


Sign in to view

+import java.util.Set;
+
+/** Interface for classes that create parts of Http requests from a parameterized message. */
+public interface HttpRequestFormatter<MessageFormatT> {


andreamlin · 2017-08-25T22:31:07Z

Addressed comments.
PTAL

Sign in to view

+ return new Builder<>();
+ }
+
+ public static class Builder<RequestT, ResponseT> {


Sign in to view

+
+ public final Builder<RequestT, ResponseT> toBuilder() {
+ return new Builder<>();
+ }


Sign in to view

+ private final ImmutableList<HttpJsonHeaderEnhancer> headerEnhancers;
+ private final SettableApiFuture responseFuture;
+
+ public HttpRequestRunnable(


Sign in to view

+ } catch (IOException e) {
+ responseFuture.setException(e);
+ }
+ } catch (Exception e) {


Sign in to view

+import java.util.Map;
+
+/** A runnable object that creates and executes an HTTP request. */
+public class HttpRequestRunnable<RequestT, ResponseT> implements Runnable {


Sign in to view

+ Set<String> pathParams,
+ Set<String> queryParams,
+ HttpRequestFormatter httpRequestFormatter,
+ String httpMethod) {


Sign in to view

+ PATCH,
+ POST,
+ PUT,
+ TRACE;


Sign in to view

 this.headerEnhancers = ImmutableList.copyOf(headerEnhancers);
+
+ HttpTransport httpTransport = new NetHttpTransport();
+ this.httpTransport = httpTransport;


andreamlin · 2017-08-26T14:45:34Z

Addressed comments.
PTAL

garrettjonesgoogle

LGTM

Starting implementation for HTTP/JSON. This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project.

correct license on MockHttpService remove unused de/serialization methods in ApiMethodDescriptor comments comments for MockHttpService Bootstrapping gax-httpjson (googleapis#355) Http implementation (googleapis#361) Starting implementation for HTTP/JSON. This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project. Retry and failure-handling logic for http-json (googleapis#363) Exception handling and retry logic for http calls. Merge master (googleapis#364) Merge in updates from the master branch. new HttpApiExceptionFactory that uses googleapis/rpc/code.proto to map http status codes to wrapper exception types RetryTest passes removed HttpJsonApiException.java no longer need to check status code when catching specific apiexception ??? removed unused file adding Struct class comments moving ResourceName stuff to ApiMessage pushing ResourceNameStruct into ApiMethodDescriptor and out of ApiMessage add license getFieldValue() updated remove resourcenamestruct and replace with new resourcenamefactory class; this depends on api-common PR formatting apimessage.getFieldSTringValue doesn't throw IOException ResourseNameFactory uses parse() instead of parseFrom() no need to declare throws IllegalArgumentException" setSerializer->setMethodDescriptor fix license header

andreamlin requested review from garrettjonesgoogle and removed request for garrettjonesgoogle August 25, 2017 18:09

andreamlin changed the base branch from master to gax-httpjsonAugust 25, 2017 18:10

andreamlin closed this Aug 25, 2017

andreamlin reopened this Aug 25, 2017

andreamlin added 24 commits August 25, 2017 11:54

ApiMessage as an interface
ce8351f

comments
89dc19f

basic constructors for ApiMethodDescriptor
8480a90

adding gson to build.gradle and made ApiMethodDescriptor an AutoValue…
c8d3a88
… class

comments
c242d4c

default HttpJsonCallOptions
5423b69

using global instance of NetHttpTransport as httptransport object
d319c88

uncompileable changes to ApiMethodDescriptor
5b28bf9

uncompileable changes to ApiMethodDescriptor
f2d6e34

cleaner ApiMethodDescriptor
3ed61de

using methoddescriptor in issuing unarycall
aa219b6

managedhttpjsonchannel actually marshalls objects
63478c0

integrating ApiMessage into ManagedHttpJsonChannel
f34e3fc

made ApiMethodDescriptor AutoValue, more work in ManagedHttpJsonChannel
e5051b5

AbstractPage will turn null nextPageTokens into empty strings
a6ff124

comments
181db07

writeRequestBody writes only the body
25a4d41

apimethoddescriptor takes sets of param names
54ccd16

formatting and comments on HttpMethod
95bb1d3

requests that have non-empty bodies now work, like addresses.insert
c181a75

uncommented ApiResultRetryAlgorithm
1e1032d

s/HttpRequestBuilder/HttpRequestFormatter/g
8d3c679

moving httpTransport and httprequestfactory to be private members of …
e71074f
…managedhttpjsonchannel

adding shutdown methods to ManagedHttpJsonChannel
0a92f38

andreamlin requested a review from garrettjonesgoogle August 25, 2017 19:02

garrettjonesgoogle reviewed Aug 25, 2017
View reviewed changes

andreamlin added 8 commits August 25, 2017 13:22

betaApi
c65b1ab

another BetaApi
318abd5

creating separate class for HttpRequestRunnable
0d0c427

parameterize settableapifuture
e839d03

javadoc style comments
3c6ab2f

grammar
2f52e05

removing GoogleNetHttpTransport b/c NetHttpTransport works fine
1dbaf02

using String for HttpMethod instead of something typed
d9282c1

garrettjonesgoogle reviewed Aug 25, 2017
View reviewed changes

andreamlin added 7 commits August 26, 2017 06:58

HttpRequestRunnable is package-private
1d0e3da

private HttpRequestRunnable constructor
aeb9d59

only one try/catch block in HttpRequestRunnable.run()
d0e4323

removing HttpMethod.java
ece328d

remove ApiMethodDescriptor.toBuilder()
c68586f

default values in ApiMethodDescriptor.toBuilder()
929fd72

adding back setHttpTransport in ManagedHttpJsonChannel
6db8201

andreamlin requested a review from garrettjonesgoogle August 26, 2017 14:42

andreamlin mentioned this pull request Aug 30, 2017
Retry and failure-handling logic for http-json #363
Merged

garrettjonesgoogle approved these changes Aug 31, 2017
View reviewed changes

andreamlin merged commit 5e4a386 into googleapis:gax-httpjsonAug 31, 2017

andreamlin deleted the http_implementation branch August 31, 2017 04:42

Uh oh!

Conversation

andreamlin commented Aug 25, 2017

Uh oh!

codecov-io commented Aug 25, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andreamlin commented Aug 25, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Aug 25, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

codecov-io commented Aug 25, 2017•
edited
Loading