Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Merge master - #364

Merged
andreamlin merged 5 commits into
googleapis:gax-httpjsonfrom
andreamlin:merge_master
Aug 31, 2017
Merged

Merge master#364
andreamlin merged 5 commits into
googleapis:gax-httpjsonfrom
andreamlin:merge_master

Conversation

@andreamlin

Copy link
Copy Markdown
Contributor

Merge in updates from the master branch.

Implementation for something similar to #357 will come in a later PR. This is just a sync PR.

@andreamlin

Copy link
Copy Markdown
ContributorAuthor

PTAL

@codecov-io

codecov-io commented Aug 31, 2017

Copy link
Copy Markdown

Codecov Report

Merging #364 into gax-httpjson will decrease coverage by 1.89%.
The diff coverage is 18.01%.

Impacted file tree graph

@@ Coverage Diff @@## gax-httpjson #364 +/- ##
=================================================
- Coverage 67.73% 65.83% -1.9% - Complexity 535 542 +7 
=================================================
Files 135 151 +16 Lines 3065 3161 +96 Branches 215 215 =================================================
+ Hits 2076 2081 +5 - Misses 908 996 +88 - Partials 81 84 +3
Impacted FilesCoverage ΔComplexity Δ
...java/com/google/api/gax/rpc/InternalException.java0% <0%> (ø)0 <0> (?)
.../google/api/gax/rpc/UnimplementedApiException.java0% <0%> (ø)0 <0> (?)
...google/api/gax/rpc/ResourceExhaustedException.java0% <0%> (ø)0 <0> (?)
...va/com/google/api/gax/rpc/OutOfRangeException.java0% <0%> (ø)0 <0> (?)
...java/com/google/api/gax/rpc/NotFoundException.java0% <0%> (ø)0 <0> (?)
...m/google/api/gax/rpc/InvalidArgumentException.java0% <0%> (ø)0 <0> (?)
.../google/api/gax/rpc/DeadlineExceededException.java0% <0%> (ø)0 <0> (?)
...com/google/api/gax/rpc/AlreadyExistsException.java0% <0%> (ø)0 <0> (?)
...m/google/api/gax/rpc/UnauthenticatedException.java0% <0%> (ø)0 <0> (?)
...ava/com/google/api/gax/rpc/CancelledException.java0% <0%> (ø)0 <0> (?)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fa52b...52db7d8. Read the comment docs.

@andreamlin
andreamlin changed the base branch from master to gax-httpjsonAugust 31, 2017 17:14

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin
andreamlin merged commit 30d6965 into googleapis:gax-httpjsonAug 31, 2017
@andreamlin
andreamlin deleted the merge_master branch August 31, 2017 17:59
andreamlin added a commit to andreamlin/gax-java that referenced this pull request Mar 15, 2018
correct license on MockHttpService
remove unused de/serialization methods in ApiMethodDescriptor
comments
comments for MockHttpService
Bootstrapping gax-httpjson (googleapis#355)
Http implementation (googleapis#361)
Starting implementation for HTTP/JSON.
This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project.
Retry and failure-handling logic for http-json (googleapis#363)
Exception handling and retry logic for http calls.
Merge master (googleapis#364)
Merge in updates from the master branch.
new HttpApiExceptionFactory that uses googleapis/rpc/code.proto to map http status codes to wrapper exception types
RetryTest passes
removed HttpJsonApiException.java
no longer need to check status code when catching specific apiexception
???
removed unused file
adding Struct class
comments
moving ResourceName stuff to ApiMessage
pushing ResourceNameStruct into ApiMethodDescriptor and out of ApiMessage
add license
getFieldValue() updated
remove resourcenamestruct and replace with new resourcenamefactory class; this depends on api-common PR
formatting
apimessage.getFieldSTringValue doesn't throw IOException
ResourseNameFactory uses parse() instead of parseFrom()
no need to declare throws IllegalArgumentException"
setSerializer->setMethodDescriptor
fix license header
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@andreamlin@codecov-io@garrettjonesgoogle@vam-google@shinfan