Set rpcTimeout to be totalTimeout for non-retried methods

[andreamlin]

Fixes#711.

[andreamlin]

PTAL

[codecov]

Codecov Report

Merging #712 into master will increase coverage by 0.27%.
The diff coverage is 50%.

@@ Coverage Diff @@## master #712 +/- ##
============================================
+ Coverage 75.46% 75.74% +0.27% - Complexity 1037 1041 +4 
============================================
Files 196 196 Lines 4675 4679 +4 Branches 363 363 ============================================
+ Hits 3528 3544 +16 + Misses 986 975 -11 + Partials 161 160 -1

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/com/google/api/gax/rpc/Callables.java	67.34% <50%> (-1.55%)	10 <0> (ø)
...a/com/google/api/gax/grpc/GrpcCallableFactory.java	78.75% <0%> (+3.75%)	10% <0%> (+1%)	⬆️
...java/com/google/api/gax/grpc/GrpcCallSettings.java	78.94% <0%> (+10.52%)	5% <0%> (ø)	⬇️
...le/api/gax/grpc/GrpcUnaryRequestParamCallable.java	90% <0%> (+90%)	3% <0%> (+3%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2bf4e...19ff63b. Read the comment docs.

[andreamlin]

PTAL again, changed the implementation again to what @igorbernstein2 proposed in #711

[igorbernstein2]

I think this (and below) could use a comment. Something like:

// When retries are disabled, the total timeout can be treated as the rpc timeout.

[andreamlin]

done

[igorbernstein2]

Consider using the MockitoRule with the @Mock annotation here. See here for an example:

gax-java/gax/src/test/java/com/google/api/gax/tracing/TraceFinisherTest.java

Lines 49 to 50 in 33a57b6

	@RulepublicMockitoRulemockitoRule = MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS);
	@MockprivateApiTracermockTracer;

[andreamlin]

Sure