Update gax -> 1.47.0, guava -> 28.0-android, gson -> 2.8.5

[chingor13]

Fixes#5555

[chingor13]

Spanner tests that disable gax retries are now failing. For non-retryable methods, we started setting a timeout from the retry config but the default setting is 10 minutes for API calls so it allowed these tests to pass. We "fixed" this for Tasks by preferring the initialRpcTimeout, then maxRpcTimeout, then totalTimeout for the default timeout, but this breaks the spanner tests.

@kolea2@snehashah16 I'm not sure what the spanner tests that disable gax retries is attempting to do - if we're trying to check that disabling retries also disables timeouts, that's in direct conflict with what gax implemented in googleapis/gax-java#712.

[kolea2]

@olavloite can you weigh in here?

[olavloite]

@kolea2@chingor13@snehashah16
The Spanner client library used to disable both gax retries and timeouts by setting all retryable codes on the gapic rpc client to an empty set, and then handle all retries and timeouts itself. I added these test cases during the transition from the custom retry handling to using the default gax retry logic in order to verify the behavior in both the old and new situation. I guess we don't need the test cases for the old situation anymore, as the transition has been completed.

[olavloite]

@chingor13 I'm changing the test cases to only test for the new situation, i.e. with Gax handling of retries and timeouts enabled. One other thing that I noticed while changing these test cases is that the retry handling of streaming calls have also changed. Can you confirm that that is correct?

The following code sets a timeout for the executeStreamingSql method of Spanner. In gax 1.46.1 and earlier, setting this did not cause the method to throw a DEADLINE_EXCEEDED exception. In Gax 1.47 it does (when the execution time exceeds the timeout settings).

finalRetrySettingsretrySettings =
RetrySettings.newBuilder()
.setInitialRpcTimeout(Duration.ofMillis(500L))
.setMaxRpcTimeout(Duration.ofMillis(500L))
.setMaxAttempts(3)
.setTotalTimeout(Duration.ofMillis(1500L))
.build();
SpannerOptions.Builderbuilder =
SpannerOptions.newBuilder()
.setProjectId("[PROJECT]")
.setChannelProvider(channelProvider)
.setCredentials(NoCredentials.getInstance());
builder
.getSpannerStubSettingsBuilder()
.executeStreamingSqlSettings()
.setRetrySettings(retrySettings);
...
// In gax 1.46.1 and earlier, this will succeed.// In gax 1.47, this will throw a DEADLINE_EXCEEDED.mockSpanner.setExecuteStreamingSqlExecutionTime(ONE_SECOND);
try (ResultSetrs = client.singleUse().executeQuery(SELECT1AND2)) {
while (rs.next()) {}
}

[olavloite]

The enclosed patch should fix the broken test cases by removing all test cases with gax disabled. Also, the test case for executeStreamingSql has been updated to reflect the fact that it now does throw a DEADLINE_EXCEEDED when a timeout has been set.

fix-spanner-test-cases.zip

[sduskis]

@olavloite, can you please submit a separate PR for those changes?

[olavloite]

@sduskis PR for this change can be found here: #5625

I've (temporarily) disabled the test case for executeStreamingSql as that test case would fail in gax 1.46.

[codecov]

Codecov Report

Merging #5590 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #5590 +/- ##
=========================================
Coverage 46.71% 46.71% Complexity 24627 24627 =========================================
Files 2351 2351 Lines 256125 256125 Branches 29325 29325 =========================================
Hits 119648 119648 Misses 127559 127559 Partials 8918 8918

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f05725...5fbaa37. Read the comment docs.