Skip to content

WIP: Upgrade proto-google-common-protos to 1.14.0. - #4486

Closed
kolea2 wants to merge 1 commit into
googleapis:masterfrom
kolea2:proto-upgrade
Closed

WIP: Upgrade proto-google-common-protos to 1.14.0.#4486
kolea2 wants to merge 1 commit into
googleapis:masterfrom
kolea2:proto-upgrade

Conversation

@kolea2

Copy link
Copy Markdown
Contributor

No description provided.

@kolea2
kolea2 requested a review from a teamFebruary 12, 2019 23:54
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@kolea2kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 12, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kolea2

Copy link
Copy Markdown
ContributorAuthor

@andreamlin do you know if this needs to be upgraded in gax as well?

@andreamlin

Copy link
Copy Markdown
Contributor

@kolea2 gax 1.39.0 has this new common protos v1.14.0 now!

@andreamlinandreamlin mentioned this pull request Feb 14, 2019
@andreamlin

Copy link
Copy Markdown
Contributor

Hey @kolea2 as part of #4496 it was suggested to also bump the proto-google-common-protos there so we could have the same versions of deps across the board at once.

@sduskissduskis closed this Feb 15, 2019
@kolea2kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 19, 2019
@kolea2
kolea2 deleted the proto-upgrade branch March 22, 2019 15:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kolea2@andreamlin@sduskis@googlebot@yoshi-kokoro