Uh oh!
There was an error while loading. Please reload this page.
Bump gax-java dependency - #4496
Merged
Merged
Conversation
andreamlin
commented
Feb 14, 2019
ContributorAuthor
PTAL |
sduskis
commented
Feb 14, 2019
Contributor
Can you please upgrade the other dependencies that changed in gax? (I know that at least grpc and opencensus were upgraded) |
sduskis
commented
Feb 14, 2019
Contributor
Should we update common proto here instead of #4486? |
andreamlin
commented
Feb 14, 2019
ContributorAuthor
Ok, also updated the common protos dep |
sduskis
commented
Feb 14, 2019
Contributor
Sorry to do this... After this exercise we should consider moving common properties up to the root pom. |
Contributor
It looks like there is a convergence issue: |
andreamlin
commented
Feb 15, 2019
ContributorAuthor
@sduskis is it ok now? i just forgot to bump google-cloud-logging's dep on gax |
sduskis
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep the same common-protos dependency at 1.14.0 as in #4486