Skip to content

Bump gax-java dependency - #4496

Merged
sduskis merged 4 commits into
googleapis:masterfrom
andreamlin:bump_gax
Feb 15, 2019
Merged

Bump gax-java dependency#4496
sduskis merged 4 commits into
googleapis:masterfrom
andreamlin:bump_gax

Conversation

@andreamlin

@andreamlinandreamlin commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

To keep the same common-protos dependency at 1.14.0 as in #4486

@andreamlin
andreamlin requested a review from a teamFebruary 14, 2019 20:35
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019
@andreamlin

Copy link
Copy Markdown
ContributorAuthor

PTAL

@sduskis

Copy link
Copy Markdown
Contributor

Can you please upgrade the other dependencies that changed in gax? (I know that at least grpc and opencensus were upgraded)

@sduskis

Copy link
Copy Markdown
Contributor

Should we update common proto here instead of #4486?

@andreamlin

Copy link
Copy Markdown
ContributorAuthor

Ok, also updated the common protos dep

@sduskis

Copy link
Copy Markdown
Contributor

Sorry to do this... google-api-grpc also has grpc dependencies (and maybe others?) that also need to be update.

After this exercise we should consider moving common properties up to the root pom.

@sduskis

sduskis commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

It looks like there is a convergence issue:

[ERROR] Failed to execute goal on project google-cloud-examples: Could not resolve dependencies for project com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Failed to collect dependencies for com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Could not resolve version conflict among [
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT -> com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
io.grpc:grpc-protobuf:jar:1.18.0 ->
io.grpc:grpc-core:jar:1.18.0,
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
io.grpc:grpc-protobuf:jar:1.18.0 ->
io.grpc:grpc-protobuf-lite:jar:1.18.0 ->
io.grpc:grpc-core:jar:1.18.0,
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
io.grpc:grpc-stub:jar:1.18.0 ->
io.grpc:grpc-core:jar:1.18.0,
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
io.grpc:grpc-auth:jar:1.18.0 ->
io.grpc:grpc-core:jar:[1.18.0,1.18.0],
com.google.cloud:google-cloud-datastore:jar:1.62.1-SNAPSHOT ->
io.grpc:grpc-core:jar:1.18.0,
com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
com.google.api:gax-grpc:jar:1.38.0 ->
io.grpc:grpc-netty-shaded:jar:1.17.1 ->
io.grpc:grpc-core:jar:[1.17.1,1.17.1],
com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
com.google.api:gax-grpc:jar:1.38.0 ->
io.grpc:grpc-alts:jar:1.17.1 ->
io.grpc:grpc-core:jar:[1.17.1,1.17.1],
com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
com.google.api:gax-grpc:jar:1.38.0 ->
io.grpc:grpc-alts:jar:1.17.1 ->
io.grpc:grpc-grpclb:jar:1.17.1 ->
io.grpc:grpc-core:jar:[1.17.1,1.17.1],
com.google.cloud:google-cloud-spanner:jar:1.7.1-SNAPSHOT ->
io.opencensus:opencensus-contrib-grpc-util:jar:0.18.0 ->
io.grpc:grpc-core:jar:1.14.0] ->

@andreamlin

Copy link
Copy Markdown
ContributorAuthor

@sduskis is it ok now? i just forgot to bump google-cloud-logging's dep on gax

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andreamlin@sduskis@googlebot