Skip to content

Bigtable: add a helper method to easily connect to an emulator - #4506

Merged
igorbernstein2 merged 6 commits into
googleapis:masterfrom
igorbernstein2:settings-2
Feb 20, 2019
Merged

Bigtable: add a helper method to easily connect to an emulator#4506
igorbernstein2 merged 6 commits into
googleapis:masterfrom
igorbernstein2:settings-2

Conversation

@igorbernstein2

@igorbernstein2igorbernstein2 commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Extracted from #4498

@igorbernstein2igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2019
@igorbernstein2
igorbernstein2 requested a review from a teamFebruary 15, 2019 19:13
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@igorbernstein2igorbernstein2 mentioned this pull request Feb 15, 2019
Closed
@igorbernstein2
Merge remote-tracking branch 'origin/master' into settings-2
c66c089
# Conflicts:
#	google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
#	google-cloud-testing/google-cloud-bigtable-emulator/README.md
@codecov

codecovBot commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4506 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #4506 +/- ##
============================================
- Coverage 49.16% 49.15% -0.01% 
Complexity 21929 21929 ============================================
Files 2077 2077 Lines 207074 207103 +29 Branches 24097 24097 ============================================
- Hits 101801 101795 -6 - Misses 97100 97135 +35 
Partials 8173 8173
Impacted FilesCoverage ΔComplexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java24.52% <0%> (-10.61%)3 <0> (ø)
.../bigtable/admin/v2/BigtableTableAdminSettings.java69.04% <0%> (-30.96%)6 <0> (ø)
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java80% <0%> (-4.62%)14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344fdac...5f033ea. Read the comment docs.

@igorbernstein2
igorbernstein2 merged commit e6cf8d3 into googleapis:masterFeb 20, 2019
@igorbernstein2
igorbernstein2 deleted the settings-2 branch February 20, 2019 15:25
@JesseLovelaceJesseLovelace mentioned this pull request Feb 21, 2019
Merged
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@igorbernstein2
Bigtable: add a helper method to easily connect to an emulator (googl…
c0bac68
…eapis#4506)
* Bigtable: add a helper method to easily connect to an emulator
* fix bad merge
* format
* use emulator helper in tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sduskissduskissduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@sduskis@googlebot