Uh oh!
There was an error while loading. Please reload this page.
Bigtable: make client settings more consistent - #4498
Closed
igorbernstein2 wants to merge 7 commits into
Closed
Conversation
The eventual goal is to deemphasize per method RPC settings by relegating them to stubSettings. And promote more common settings like credentials to the top level. This breaks backwards compatibility by removing BigtableDataSettings' base class. It tries to ease the transition by copying the ClientSettings methods down into BigtableDataSettings. Specific changes: - BigtableDataSettings is no longer a subclass of ClientSettings - ClientSettings methods have been temporarily copied to BigtableDataSettings with deprecation warnings to ease transition - add helper method to ease connection to emulator - make sure that credential provider is configurable at the top level (fixesgoogleapis#3634) - all of the deprecated methods have been grouped together and will be removed in the next couple of releases (along with the deprecated google-bigtable-admin artifact)
Codecov Report
@@ Coverage Diff @@## master #4498 +/- ##
============================================
- Coverage 49.16% 49.15% -0.02% - Complexity 21915 21917 +2
============================================
Files 2078 2078 Lines 207084 207152 +68 Branches 24084 24084 ============================================
+ Hits 101815 101818 +3 - Misses 97126 97191 +65
Partials 8143 8143
Continue to review full report at Codecov.
|
sduskis
commented
Feb 15, 2019
Contributor
@igorbernstein2, it looks like all tests are failing now. |
# Conflicts: # google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ResourceHeaderTest.java
igorbernstein2
commented
Feb 15, 2019
ContributorAuthor
I think it was just a merge conflict |
sduskis
reviewed
Feb 15, 2019
sduskis
left a comment
Contributor
There was a problem hiding this comment.
There are a lot of different threads of work here. Can you please break down this work into smaller PRs so that the reviewing can be more effective?
This was referenced Feb 15, 2019
igorbernstein2
commented
Feb 15, 2019
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eventual goal is to deemphasize per method RPC settings by relegating them to stubSettings. And promote more common settings like credentials to the top level.
This breaks backwards compatibility by removing BigtableDataSettings' base class. It tries to ease the transition by copying the ClientSettings methods down into BigtableDataSettings.
Specific changes:
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)