Uh oh!
There was an error while loading. Please reload this page.
Bigtable: Deemphasize most of the settings and move them to the StubSettings - #4509
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #4509 +/- ##
=========================================
Coverage ? 49.15% Complexity ? 21929 =========================================
Files ? 2077 Lines ? 207109 Branches ? 24097 =========================================
Hits ? 101804 Misses ? 97132 Partials ? 8173
Continue to review full report at Codecov.
|
…ettings This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings
igorbernstein2force-pushed
the
settings--5
branch
from
February 17, 2019 20:29
d787160 to
0fae43fCompare# Conflicts: # google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
sduskis
approved these changes
Feb 20, 2019
benjaminp pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…ettings (googleapis#4509) * Bigtable: Deemphasize most of the settings and move them to the StubSettings This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings * format * fix bad merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings
Extracted from #4498