Uh oh!
There was an error while loading. Please reload this page.
More Pubsub cleanup - #4948
Merged
Merged
Conversation
- Removing PublisherStats, since it's package private and not used anywhere. - StatusUtil and SubscriberStats are package private. Remove the `public` modifier on methods in those classes
Codecov Report
@@ Coverage Diff @@## master #4948 +/- ##
=========================================
Coverage ? 50.36% Complexity ? 23665 =========================================
Files ? 2232 Lines ? 225852 Branches ? 24956 =========================================
Hits ? 113742 Misses ? 103513 Partials ? 8597
Continue to review full report at Codecov.
|
kolea2
reviewed
Apr 15, 2019
Uh oh!
There was an error while loading. Please reload this page.
Contributor
This LGTM, but I had a question regarding the MessageDispatcher change in #4949. It looks like this change made it into both PRs, can you remove it from this one, I'll approve, and we can follow up on the other PR separately? |
sduskis
commented
Apr 15, 2019
ContributorAuthor
@kolea2, done. |
kolea2
approved these changes
Apr 16, 2019
meltsufin pushed a commit
that referenced
this pull request
Apr 29, 2026
* More Pubsub cleanup - Removing PublisherStats, since it's package private and not used anywhere. - StatusUtil and SubscriberStats are package private. Remove the `public` modifier on methods in those classes * Reverting MessageDispatcher change.
meltsufin pushed a commit
that referenced
this pull request
May 1, 2026
* More Pubsub cleanup - Removing PublisherStats, since it's package private and not used anywhere. - StatusUtil and SubscriberStats are package private. Remove the `public` modifier on methods in those classes * Reverting MessageDispatcher change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publicmodifier on methods in those classes