Skip to content

Cleaning up deprecated pubsub code. - #4949

Merged
sduskis merged 3 commits into
googleapis:masterfrom
sduskis:cleanup_pubsub_4
Apr 16, 2019
Merged

Cleaning up deprecated pubsub code.#4949
sduskis merged 3 commits into
googleapis:masterfrom
sduskis:cleanup_pubsub_4

Conversation

@sduskis

Copy link
Copy Markdown
Contributor

No description provided.

@sduskis
sduskis requested a review from a teamApril 15, 2019 14:37
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@codecov

codecovBot commented Apr 15, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@2fc4e55). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@ Coverage Diff @@## master #4949 +/- ##
=========================================
Coverage ? 50.36% Complexity ? 23674 =========================================
Files ? 2233 Lines ? 225860 Branches ? 24952 =========================================
Hits ? 113744 Misses ? 103519 Partials ? 8597
Impacted FilesCoverage ΔComplexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java64.75% <0%> (ø)9 <0> (?)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java85.56% <100%> (ø)22 <2> (?)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java81.05% <100%> (ø)26 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc4e55...8bbefbe. Read the comment docs.

@kolea2kolea2 mentioned this pull request Apr 15, 2019
@sduskis
sduskis merged commit e5e7a21 into googleapis:masterApr 16, 2019
@sduskis
sduskis deleted the cleanup_pubsub_4 branch April 16, 2019 14:59
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
* Cleaning up deprecated pubsub code.
* Fixing format
meltsufin pushed a commit that referenced this pull request May 1, 2026
* Cleaning up deprecated pubsub code.
* Fixing format
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis@kolea2@googlebot