Uh oh!
There was an error while loading. Please reload this page.
Spanner: Fix test cases for gax 1.47 - #5625
Merged
Merged
Conversation
kolea2
approved these changes
Jul 1, 2019
Codecov Report
@@ Coverage Diff @@## master #5625 +/- ##
=========================================
Coverage 46.71% 46.71% Complexity 24627 24627 =========================================
Files 2351 2351 Lines 256125 256125 Branches 29325 29325 =========================================
Hits 119648 119648 Misses 127559 127559 Partials 8918 8918Continue to review full report at Codecov.
|
This was referenced Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spanner client used to disable gax retries and timeouts by setting the retryable status codes on the gapic client to an empty set. Setting these codes to an empty set does not disable timeouts in gax 1.47. All test cases that tested this condition have been removed.