Skip to content

Firestore:Fix make change in CustomClassMapper serialize and deserialize methods to public - #5879

Closed
abhinav-qlogic wants to merge 3 commits into
googleapis:masterfrom
abhinav-qlogic:api-firestore-5809
Closed

Firestore:Fix make change in CustomClassMapper serialize and deserialize methods to public#5879
abhinav-qlogic wants to merge 3 commits into
googleapis:masterfrom
abhinav-qlogic:api-firestore-5809

Conversation

@abhinav-qlogic

Copy link
Copy Markdown

Fixes#5809

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019

@dmitry-sdmitry-s left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
just wanted to point out that the class is currently package-private. It needs to be public so we can use it outside of the package. Otherwise looks good!

@codecov

codecovBot commented Jul 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5879 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #5879 +/- ##
============================================
- Coverage 46.79% 46.51% -0.29% 
Complexity 25648 25648 ============================================
Files 2456 2456 Lines 267593 267477 -116 Branches 30564 29752 -812 ============================================
- Hits 125229 124408 -821 + Misses 133105 133026 -79 - Partials 9259 10043 +784
Impacted FilesCoverage ΔComplexity Δ
.../com/google/cloud/firestore/CustomClassMapper.java77.29% <0%> (ø)102 <0> (ø)⬇️
...va/com/google/cloud/compute/v1/InstanceClient.java48.8% <0%> (-6.45%)143% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java47.9% <0%> (-5.99%)43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java51.14% <0%> (-5.94%)55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java49.63% <0%> (-5.84%)35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java50.41% <0%> (-5.79%)31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java50% <0%> (-5.74%)31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java49.04% <0%> (-5.74%)43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java48.57% <0%> (-5.72%)35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java48.1% <0%> (-5.7%)39% <0%> (ø)
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98c8e6...200927a. Read the comment docs.

@ajaaymajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
@BenWhitehead

Copy link
Copy Markdown
Contributor

Superseded by #6085

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make CustomClassMapper's serialization and deserialization methods public

7 participants

@abhinav-qlogic@BenWhitehead@dmitry-s@googlebot@ajaaym@pmakani@yoshi-kokoro