Skip to content

Expose Object serialization for internal consumers - #6085

Merged
schmidt-sebastian merged 3 commits into
masterfrom
mrschmidt/serializer
Aug 23, 2019
Merged

Expose Object serialization for internal consumers#6085
schmidt-sebastian merged 3 commits into
masterfrom
mrschmidt/serializer

Conversation

@schmidt-sebastian

Copy link
Copy Markdown
Contributor

This allows internal teams to create DocumentSnapshots from POJOs, Maps and the Proto.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@codecov

codecovBot commented Aug 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6085 into master will decrease coverage by 7.03%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #6085 +/- ##
============================================
- Coverage 47.38% 40.35% -7.04% + Complexity 27182 25716 -1466 
============================================
Files 2523 2524 +1 Lines 274581 220912 -53669 Branches 31380 24175 -7205 ============================================
- Hits 130123 89138 -40985 + Misses 134850 123333 -11517 + Partials 9608 8441 -1167
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java84.76% <0%> (-0.96%)55 <2> (ø)
...main/java/com/google/cloud/firestore/Internal.java0% <0%> (ø)0 <0> (?)
...ud/devtools/containeranalysis/v1/GrafeasUtils.java50% <0%> (-40.91%)1% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java61.9% <0%> (-22.97%)145% <0%> (ø)
...afeas/src/main/java/io/grafeas/v1/GrafeasGrpc.java48.32% <0%> (-18.89%)30% <0%> (ø)
...om/google/cloud/http/BaseHttpServiceException.java44.23% <0%> (-17.31%)8% <0%> (ø)
...le/cloud/compute/v1/stub/HttpJsonNodeTypeStub.java73.52% <0%> (-16.67%)9% <0%> (-1%)
...le/cloud/compute/v1/stub/HttpJsonDiskTypeStub.java73.52% <0%> (-16.67%)9% <0%> (-1%)
...cloud/compute/v1/stub/HttpJsonMachineTypeStub.java73.52% <0%> (-16.67%)9% <0%> (-1%)
...google/cloud/compute/v1/stub/HttpJsonZoneStub.java71.42% <0%> (-16.08%)8% <0%> (-1%)
... and 1908 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daf76a...0e78c19. Read the comment docs.

@schmidt-sebastian

Copy link
Copy Markdown
ContributorAuthor

@BenWhitehead Is there anything special I need to do regarding the formatting? I have re-installed my Maven dependencies and mvn com.coveo:fmt-maven-plugin:format doesn't show me a diff anymore, yet the verification still fails.

@schmidt-sebastian

Copy link
Copy Markdown
ContributorAuthor

@BenWhitehead Is there anything special I need to do regarding the formatting? I have re-installed my Maven dependencies and mvn com.coveo:fmt-maven-plugin:format doesn't show me a diff anymore, yet the verification still fails.

To be clear, it did format the change the first time around.

@BenWhitehead

Copy link
Copy Markdown
Contributor

@schmidt-sebastian The new file https://github.com/googleapis/google-cloud-java/pull/6085/files#diff-c1b66da3ed37700b15f5fb4c57e0328dR1 looks like it's missing a copyright header and that's why it's failing.

@schmidt-sebastian

Copy link
Copy Markdown
ContributorAuthor

Thanks :) It's passing now.

@schmidt-sebastian
schmidt-sebastian merged commit f58cce7 into masterAug 23, 2019
@Neenu1995
Neenu1995 deleted the mrschmidt/serializer branch July 6, 2022 17:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian@BenWhitehead@googlebot