Skip to content

refactor(bigquery): update code samples of load table autodetect and truncate - #10176

Closed
HemangChothani wants to merge 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_update_load_table_autodetect_truncate_code_sample
Closed

refactor(bigquery): update code samples of load table autodetect and truncate#10176
HemangChothani wants to merge 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_update_load_table_autodetect_truncate_code_sample

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Jan 21, 2020

Copy link
Copy Markdown
Contributor

Towards #8989

List of changes:

  1. load_table_uri_autodetect_csv
  2. load_table_uri_autodetect_json
  3. load_table_uri_truncate_avro.py
  4. load_table_uri_truncate_json.py
  5. load_table_uri_truncate_csv.py
  6. load_table_uri_truncate_orc.py
  7. load_table_uri_truncate_parquet.py

@HemangChothani
HemangChothani requested review from a team and tswastJanuary 21, 2020 12:56
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
@plamut

plamut commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

(not a complete review in any way, just a remark)

Shouldn't the copyright notice contain the year 2020 in new files?

@HemangChothani

HemangChothani commented Jan 24, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

test_client_load_partitioned_table snippet failed is unrelated to changes.

@plamutplamut mentioned this pull request Jan 24, 2020
Merged
@plamut

plamut commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

The failing snippet test is fixed in #10195.

@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@plamutplamut added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2020
@plamutplamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2020
@plamut

plamut commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

Starting the repo split, please do not merge.

@plamut

plamut commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

The repo split for BigQuery is done, please re-open the PR in the new repo, thanks!

https://github.com/googleapis/python-bigquery

@plamut

plamut commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Superseded by googleapis/python-bigquery#28

@plamutplamut closed this Feb 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswastAwaiting requested review from tswast

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HemangChothani@plamut@googlebot@yoshi-kokoro