Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

refactor(bigquery): update code samples of load table autodetect and truncate - #28

Merged
HemangChothani merged 9 commits into
googleapis:masterfrom
HemangChothani:bigquery_update_load_table_autodetect_truncate_code_sample
May 13, 2020
Merged

refactor(bigquery): update code samples of load table autodetect and truncate#28
HemangChothani merged 9 commits into
googleapis:masterfrom
HemangChothani:bigquery_update_load_table_autodetect_truncate_code_sample

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Move the snippets to their own sample files

List of changes:

  1. load_table_uri_autodetect_csv
  2. load_table_uri_autodetect_json
  3. load_table_uri_truncate_avro.py
  4. load_table_uri_truncate_json.py
  5. load_table_uri_truncate_csv.py
  6. load_table_uri_truncate_orc.py
  7. load_table_uri_truncate_parquet.py

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@HemangChothani
HemangChothaniforce-pushed the bigquery_update_load_table_autodetect_truncate_code_sample branch from 471439d to a1bcbceCompareFebruary 6, 2020 13:05
@plamutplamut mentioned this pull request Feb 10, 2020
Closed
plamut
plamut approved these changes Feb 10, 2020
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
tswast requested review from shollyman and removed request for tswastMarch 3, 2020 17:10
@plamut

plamut commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

@shollyman Do you have anything to add here?

plamutand others added 2 commits April 7, 2020 12:46
@HemangChothani

HemangChothani commented Apr 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@shollyman PTAL!

@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@HemangChothani
Merge branch 'master' ofhttps://github.com/googleapis/python-bigquery…
4143c63
…into bigquery_update_load_table_autodetect_truncate_code_sample
@HemangChothani
Merge branch 'master' ofhttps://github.com/googleapis/python-bigquery…
1167f54
…into bigquery_update_load_table_autodetect_truncate_code_sample
@HemangChothani

HemangChothani commented May 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@shollyman Friendly ping. :)

shollyman
shollyman approved these changes May 12, 2020
View reviewed changes

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and being patient with a terribly slow reviewer.

@HemangChothani
HemangChothani merged commit 18eb9e8 into googleapis:masterMay 13, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@shollymanshollymanshollyman approved these changes
@plamutplamutplamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HemangChothani@plamut@shollyman@googlebot@yoshi-kokoro