Uh oh!
There was an error while loading. Please reload this page.
Add search indexes - #1165
Merged
Merged
Conversation
dhermes
commented
Oct 1, 2015
Contributor
Ping me here when #1164 is in (or at least once that review is done) |
tseaver
commented
Oct 6, 2015
ContributorAuthor
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Oct 6, 2015
Contributor
Sorry for the delayed review. I accidentally knocked this PR out of my task queue. |
dhermes
commented
Oct 6, 2015
Contributor
LGTM. (Would still like to know about CRUD ops on indexes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1164 as a base.