Skip to content

Initial commit of Cloud Search API - #972

Closed
jgeewax wants to merge 1 commit into
googleapis:masterfrom
jgeewax:search
Closed

Initial commit of Cloud Search API#972
jgeewax wants to merge 1 commit into
googleapis:masterfrom
jgeewax:search

Conversation

@jgeewax

@jgeewaxjgeewax commented Jul 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2015
@jgeewaxjgeewax added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 7, 2015
@jgeewax
jgeewaxforce-pushed the search branch 2 times, most recently from c23dec4 to 60a2d6fCompareJuly 7, 2015 14:45
@dhermes

dhermes commented Jul 7, 2015

Copy link
Copy Markdown
Contributor

21 files in one commit is a mouthful! Can you start with an MVP and build up for the sake of review? The bigger the PR is, the less a chance any line actually has of being reviewed.

Also, it looks like you are using _Monkey on objects, but IIUC @tseaver only ever intended it to be used on modules.

@jgeewax

jgeewax commented Jul 7, 2015

Copy link
Copy Markdown
ContributorAuthor

@dhermes : Still don't merge. Want me to delete the PR until it's ready ? (_Monkey is all gone)

I get that it's a mouthful..... I can .... stop adding stuff now... but ... tearing it apart seems like a boatload of extra work just to put it back in... Any other ideas?

@jgeewax

jgeewax commented Jul 7, 2015

Copy link
Copy Markdown
ContributorAuthor

Maybe we can start with just the search-api.rst file...?

@dhermes

dhermes commented Jul 7, 2015

Copy link
Copy Markdown
Contributor

It is a boatload of work, but we would never let a new contributor make a PR with a brain dump, so we should hold ourselves to the same standard. The quality of review goes down and burden on reviewers goes way up when the PR is a behemoth. At the very least it should be separated into small commits encapsulating single ideas.

Start with a skeleton of each class/method and then build out features piecemeal.

If you don't have cycles for it, I can pull apart your PR to make it easy to review.

@tseavertseaver mentioned this pull request Sep 30, 2015
Merged
@tseaver

tseaver commented Oct 14, 2015

Copy link
Copy Markdown
Contributor

Obsoleted by #1162, #1164, #1165, #1173, #1177, #1178, #1179, #1183, #1184

@tseavertseaver closed this Oct 14, 2015
parthea pushed a commit that referenced this pull request Sep 4, 2025
@renovate-bot
chore(deps): update all dependencies (#972)
70f20b1
parthea pushed a commit that referenced this pull request Sep 16, 2025
@renovate-bot@parthea
chore(deps): update all dependencies (#972)
de8ef35
parthea added a commit that referenced this pull request Nov 22, 2025
@gcf-owl-bot@parthea
fix: Allow protobuf 5.x (#972)
2bab5ae
* chore: Update gapic-generator-python to v1.18.0
PiperOrigin-RevId: 638650618
Source-Link: googleapis/googleapis@6330f03
Source-Link: googleapis/googleapis-gen@44fa4f1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
* feat(spanner): Add support for Cloud Spanner Scheduled Backups
PiperOrigin-RevId: 649277844
Source-Link: googleapis/googleapis@fd7efa2
Source-Link: googleapis/googleapis-gen@50be251
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9
* feat: publish the Cloud Bigtable ExecuteQuery API
The ExecuteQuery API will allow users to query Bigtable using SQL
PiperOrigin-RevId: 650660213
Source-Link: googleapis/googleapis@f681f79
Source-Link: googleapis/googleapis-gen@3180845
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE4MDg0NTQ4NzEzNjc5NDk1MmI4ZjM2NWZlNmM2ODY4OTk5ZDljMCJ9
* feat: publish ProtoRows Message
This is needed to parse ExecuteQuery responses
PiperOrigin-RevId: 651386373
Source-Link: googleapis/googleapis@a5be6fa
Source-Link: googleapis/googleapis-gen@d467ce8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDQ2N2NlODkzYTA0YzQxZTUwNDk4MzM0NmMyMTVkNDFmZDI2MzY1MCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update setup.py to match googleapis/gapic-generator-python/blob/main/gapic/templates/setup.py.j2
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update constraints
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.51.0 (#972)
b790ea3
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot@tswast
chore(deps): update dependency pyarrow to v22 (#972)
05b55ec
* chore(deps): update dependency pyarrow to v22
* don't upgrade on 3.9
Updated pyarrow version constraints based on Python version.
---------
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dandhlee@gkevinzheng
docs: update README to break infinite redirect loop (#972)
b8884d6
googleapis.dev link has been deprecated and redirected.
Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@dandhlee@gkevinzheng
docs: update README to break infinite redirect loop (#972)
d92ea56
googleapis.dev link has been deprecated and redirected.
Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@arithmetic1728
chore: update user creds for sys test (#972)
3ac9c15
parthea added a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot@parthea
fix: Allow protobuf 5.x (#972)
0112a80
* chore: Update gapic-generator-python to v1.18.0
PiperOrigin-RevId: 638650618
Source-Link: googleapis/googleapis@6330f03
Source-Link: googleapis/googleapis-gen@44fa4f1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
* feat(spanner): Add support for Cloud Spanner Scheduled Backups
PiperOrigin-RevId: 649277844
Source-Link: googleapis/googleapis@fd7efa2
Source-Link: googleapis/googleapis-gen@50be251
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9
* feat: publish the Cloud Bigtable ExecuteQuery API
The ExecuteQuery API will allow users to query Bigtable using SQL
PiperOrigin-RevId: 650660213
Source-Link: googleapis/googleapis@f681f79
Source-Link: googleapis/googleapis-gen@3180845
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE4MDg0NTQ4NzEzNjc5NDk1MmI4ZjM2NWZlNmM2ODY4OTk5ZDljMCJ9
* feat: publish ProtoRows Message
This is needed to parse ExecuteQuery responses
PiperOrigin-RevId: 651386373
Source-Link: googleapis/googleapis@a5be6fa
Source-Link: googleapis/googleapis-gen@d467ce8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDQ2N2NlODkzYTA0YzQxZTUwNDk4MzM0NmMyMTVkNDFmZDI2MzY1MCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update setup.py to match googleapis/gapic-generator-python/blob/main/gapic/templates/setup.py.j2
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update constraints
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
@tswast
fix!: remove out-of-date BigQuery ML protocol buffers (#1178)
b9c6ec6
deps!: BigQuery Storage and pyarrow are required dependencies (#776)
fix!: use nullable `Int64` and `boolean` dtypes in `to_dataframe` (#786) feat!: destination tables are no-longer removed by `create_job` (#891)
feat!: In `to_dataframe`, use `dbdate` and `dbtime` dtypes from db-dtypes package for BigQuery DATE and TIME columns (#972)
fix!: automatically convert out-of-bounds dates in `to_dataframe`, remove `date_as_object` argument (#972)
feat!: mark the package as type-checked (#1058)
feat!: default to DATETIME type when loading timezone-naive datetimes from Pandas (#1061)
feat: add `api_method` parameter to `Client.query` to select `INSERT` or `QUERY` API (#967)
fix: improve type annotations for mypy validation (#1081)
feat: use `StandardSqlField` class for `Model.feature_columns` and `Model.label_columns` (#1117)
docs: Add migration guide from version 2.x to 3.x (#1027)
Release-As: 3.0.0
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.13.12 (#972)
e1aebdc
parthea pushed a commit that referenced this pull request Mar 9, 2026
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.3 (#972)
f3c9dae
* chore: Update gapic-generator-python to v1.11.3
PiperOrigin-RevId: 546899192
Source-Link: googleapis/googleapis@e6b1691
Source-Link: googleapis/googleapis-gen@0b3917c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgeewax@dhermes@tseaver@googlebot