Skip to content

Streaming: add pep8 / pylint goodness - #1210

Merged
tseaver merged 17 commits into
googleapis:masterfrom
tseaver:streaming-pep8_pylint
Nov 19, 2015
Merged

Streaming: add pep8 / pylint goodness#1210
tseaver merged 17 commits into
googleapis:masterfrom
tseaver:streaming-pep8_pylint

Conversation

@tseaver

@tseavertseaver commented Oct 29, 2015

Copy link
Copy Markdown
Contributor

Uses #1209 as a base.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2015
@tseavertseaver mentioned this pull request Oct 29, 2015
Merged
@tseavertseaver mentioned this pull request Nov 6, 2015
Closed
5 tasks
@tseaver

tseaver commented Nov 19, 2015

Copy link
Copy Markdown
ContributorAuthor

@dhermes rebased after merge of #1209.

@dhermes

dhermes commented Nov 19, 2015

Copy link
Copy Markdown
Contributor

Theres a bit more than PEP8 changes in "Get 'pep8' working on 'gcloud/streaming'." (e.g. dropping request = _Request() and using self.URL in test_transfer.py). No worries though, just an observation, the commit is all good.

dhermes
dhermes reviewed Nov 19, 2015
View reviewed changes
Comment threadgcloud/streaming/exceptions.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Nov 19, 2015
View reviewed changes
Comment threadgcloud/streaming/transfer.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Nov 19, 2015

Copy link
Copy Markdown
Contributor

Finished review

@dhermesdhermes mentioned this pull request Nov 19, 2015
Closed
@tseavertseaver mentioned this pull request Nov 19, 2015
Closed
@dhermes

dhermes commented Nov 19, 2015

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request Nov 19, 2015
@tseaver
Merge pull request#1210from tseaver/streaming-pep8_pylint
46d8253
Streaming: add pep8 / pylint goodness
@tseaver
tseaver merged commit 46d8253 into googleapis:masterNov 19, 2015
@tseaver
tseaver deleted the streaming-pep8_pylint branch November 19, 2015 18:00
@dhermesdhermes mentioned this pull request Jan 25, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@busunkim96@software-dov@parthea
fix: fix snippet region tag format (#1210)
7e6def5
* fix: fix snippet region tags
* chore: delete obsolete files
* chore: delete old files
Co-authored-by: Dov Shlachter <dovs@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update all dependencies (#1210)
c684596
parthea pushed a commit that referenced this pull request Nov 26, 2025
@arithmetic1728
chore: update systest creds and fix unit test syntax (#1210)
a27295f
* chore: update systest creds
* chore: fix unit test
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot
chore(deps): update dependency pyparsing to v3.0.8 (#1210)
2fd9bf6
parthea pushed a commit that referenced this pull request Mar 9, 2026
@gcf-owl-bot@cojenco
build(python): fixdocsanddocfxbuilds (#1210)
7a1e77a
* build(python): fix `docs` and `docfx` builds
Source-Link: googleapis/synthtool@fac8444
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa
* apply googleapis/synthtool#1916
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Cathy Ouyang <cathyo@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: corecla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot