Streaming: strip unused features by tseaver · Pull Request #1209 · googleapis/google-cloud-python

tseaver · 2015-10-29T00:29:03Z

Uses #1208 as a base.

Trim / normailze / document imports.
Rename functions / methods to match PEP 8.
Make constants / methods used outside their modules public.
Make functions / methods not imported outside their modules explicitly private.
Drop unused exceptions.

dhermes · 2015-10-29T18:11:21Z

Ping me when this is rebased after the other commits get merged.

tseaver · 2015-11-16T21:29:28Z

@dhermes rebased after #1208 merged.

dhermes · 2015-11-16T21:49:01Z

Just want to double check that 11 commits is intended after the rebase and we didn't confuse git?

tseaver · 2015-11-16T22:11:57Z

This is the correct set of commits: I can squash some down, if you think it will help review better.

dhermes · 2015-11-16T22:28:24Z

No more commits is almost certainly a good thing (easier to review).

Sign in to view

dhermes · 2015-11-16T22:34:48Z

Unfortunately GitHub thinks there are too many changes to gcloud/streaming/test_transfer.py to display.

There are a couple places where you dropped with _Monkey(MUT, http_wrapper=_Dummy()):. Why?

dhermes · 2015-11-16T22:37:21Z

Also

_Monkey(
Request=lambda url, http_method, body: _Request(url, http_method, body)
)

seems like it could be done with

_Monkey(Request=_Request)

What am I missing?

Sign in to view

dhermes · 2015-11-16T22:43:34Z

Yay for "Give 'streaming.util' functions PEP8 names."!

Sign in to view

dhermes · 2015-11-16T22:57:11Z

Rut-roh, test_transfer.py is also not visible in https://github.com/tseaver/gcloud-python/commit/2414bfbbe449db06a7a1aaae314dc1d144a24a4b

Sign in to view

dhermes · 2015-11-16T23:05:26Z

Other than getting at the code GitHub won't show me, I've reviewed them all and made my comments.

tseaver · 2015-11-17T00:46:53Z

There are a couple places where you dropped with _Monkey(MUT, http_wrapper=_Dummy()):. Why?

In that same commit, transfer begins importing names directly, rather than via http_wrapper.<name>.

tseaver · 2015-11-18T20:25:03Z

(I think) to review the bigger diff:

$ git remote add tseaver https://github.com/tseaver/gcloud-python
$ git fetch --all tseaver
$ git diff master..tseaver/streaming-strip_unused_features gcloud/streaming/test_transfer.py

…ants.

Addresses: #1209 (comment)

Addresses: #1209 (diff)

Addresses: #1209 (comment)

tseaver · 2015-11-18T21:13:32Z

Rebased to fix conflict on gcloud/storage/test_blob.py (from #1222).

dhermes · 2015-11-18T21:48:17Z

OK the test_transfer.py diff looks fine (I don't know why GitHub wouldn't show it, it was mostly renames)

dhermes · 2015-11-18T21:48:29Z

Do we have everything else squared away?

tseaver · 2015-11-19T00:40:17Z

Do we have everything else squared away?

I think so.

dhermes · 2015-11-19T00:45:34Z

OK. LGTM

Streaming: strip unused features

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [setuptools](https://togithub.com/pypa/setuptools) | `==60.9.1` -> `==60.9.2` | [![age](https://badges.renovateapi.com/packages/pypi/setuptools/60.9.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/setuptools/60.9.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/setuptools/60.9.2/compatibility-slim/60.9.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/setuptools/60.9.2/confidence-slim/60.9.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pypa/setuptools</summary> ### [`v60.9.2`](https://togithub.com/pypa/setuptools/blob/HEAD/CHANGES.rst#v6092) [Compare Source](https://togithub.com/pypa/setuptools/compare/v60.9.1...v60.9.2) Misc ^^^^ - [#3035](https://togithub.com/pypa/setuptools/issues/3035): When loading distutils from the vendored copy, rewrite `__name__` to ensure consistent importing from inside and out. </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).

* chore: update token * pin the cryptography library version * pin the cryptography library version * using less operator to try

* feat: add INTERVAL API PiperOrigin-RevId: 680405503 Source-Link: googleapis/googleapis@2c9fb37 Source-Link: googleapis/googleapis-gen@317c7d1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE3YzdkMWIxYjgwMWZlNjYzZjg3YmZkMGJhZTU0ZmQ2NTI2ZGU4NyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: update comment for PROFILE QueryMode feat: add new QueryMode enum values (WITH_STATS, WITH_PLAN_AND_STATS) PiperOrigin-RevId: 680628448 Source-Link: googleapis/googleapis@72a5151 Source-Link: googleapis/googleapis-gen@146c3e8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTQ2YzNlOGRhODc3Mzg4MDQ3MDliN2YzZDI2NGE4ZTMzYWUzOGQ3MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Define ReplicaComputeCapacity and AsymmetricAutoscalingOption docs: A comment for field `node_count` in message `spanner.admin.instance.v1.Instance` is changed docs: A comment for field `processing_units` in message `spanner.admin.instance.v1.Instance` is changed PiperOrigin-RevId: 681615472 Source-Link: googleapis/googleapis@dd47718 Source-Link: googleapis/googleapis-gen@7f0f9b7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2YwZjliNzQ2NmNiNTE3NzY5YjU0OWM1ZTJjMmI5MTI0OTI4NjJmMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: protos for R/W transaction support on multiplexed sessions PiperOrigin-RevId: 683879049 Source-Link: googleapis/googleapis@2b6b93b Source-Link: googleapis/googleapis-gen@2f0c933 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmYwYzkzM2IwMDMxNjRkNWNkMTIwNTA1YTk4Yzg3Yzk1ODg4ZDk4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.19.1 PiperOrigin-RevId: 684571179 Source-Link: googleapis/googleapis@fbdc238 Source-Link: googleapis/googleapis-gen@3a2cdcf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2EyY2RjZmI4MGMyZDBmNWVjMGNjNjYzYzJiYWIwYTk0ODYyMjlkMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(spanner): Add support for Cloud Spanner Default Backup Schedules PiperOrigin-RevId: 688946300 Source-Link: googleapis/googleapis@b11e6b0 Source-Link: googleapis/googleapis-gen@f93f56b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjkzZjU2YjIxZmYwMWU0OTk5NzdjNGRkNTQ2ODljY2UxYjdjZjUzMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Configure Ruby clients for google-ads-ad_manager PiperOrigin-RevId: 689139590 Source-Link: googleapis/googleapis@296f2ac Source-Link: googleapis/googleapis-gen@2692736 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjY5MjczNjJlMGFhMTI5MzI1OGZjMjNmZTNjZTgzYzVjMjFkNWZiYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>

tseaver added hygiene api: core labels Oct 29, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2015

This was referenced Oct 29, 2015
Streaming: add pep8 / pylint goodness #1210
Merged
Add coverage for 'gcloud._apitools.transfer' #1207
Merged

tseaver mentioned this pull request Nov 6, 2015
Re-vendor / cleanup apitools as used in storage #1186
Closed
5 tasks

dhermes reviewed Nov 16, 2015
View reviewed changes

Comment threadgcloud/streaming/buffered_stream.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 16, 2015
View reviewed changes

Comment threadgcloud/streaming/transfer.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 16, 2015
View reviewed changes

Comment threadgcloud/streaming/util.py
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 16, 2015
View reviewed changes

Comment threadgcloud/streaming/transfer.py
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

tseaver added 17 commits November 18, 2015 16:11

Unused imports.
a1a43c1

Make imports explicit, and document them.
e74b5ae

Give 'streaming.util' functions PEP8 names.
37f9ed3

Give 'streaming.http_wrapper' functions PEP8 names.
beb8b84

Further import cleanup / documentation.
b6b764d

Remove deleted APIs from 'streaming.transfer.__all__'.
2cf253b

Make 'streaming.transfer.RESUMABLE_UPLOAD_THRESHOLD' public.
bf3f706

Adjust visibility / names of 'streaming.http_wrapper' helpers / const…
3033ca6
…ants.

Strip out unused/redundant exception types.
54cb870

Give 'streaming.transfer' methos PEP8 names.
e22993e

Fix coverage gap from branch split.
73c3282

Remove pointless lambda wrapping '_Request'.
7ad47bb
Addresses: #1209 (comment)

Drop notes-to-self from module docstrings.
8caed56
Addresses: #1209 (comment)

Drop legacy '__all__'.
94fc9bf
Addresses: #1209 (diff)

Typo.
42ded7d
Addresses: #1209 (comment)

Move quasi-docstring comments into docstring for '_ExceptionRetryArgs'.
f66f1b8
Addresses: #1209 (comment)

Move nested '_process_content_range' helper out to module scope.
7e94700
Addresses: #1209 (comment)

tseaver added a commit that referenced this pull request Nov 19, 2015
Merge pull request#1209from tseaver/streaming-strip_unused_features
509564d
Streaming: strip unused features

tseaver merged commit 509564d into googleapis:masterNov 19, 2015

tseaver deleted the streaming-strip_unused_features branch November 19, 2015 01:00

dhermes mentioned this pull request Jan 25, 2016
Upgrading version to 0.9.0. #1418
Merged

parthea pushed a commit that referenced this pull request Nov 26, 2025
chore: update token (#1209)
8d63bd9
* chore: update token * pin the cryptography library version * pin the cryptography library version * using less operator to try

Uh oh!

Conversation

tseaver commented Oct 29, 2015

Uh oh!

dhermes commented Oct 29, 2015

Uh oh!

tseaver commented Nov 16, 2015

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

tseaver commented Nov 16, 2015

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 16, 2015

Uh oh!

tseaver commented Nov 17, 2015

Uh oh!

tseaver commented Nov 18, 2015

Uh oh!

tseaver commented Nov 18, 2015

Uh oh!

dhermes commented Nov 18, 2015

Uh oh!

dhermes commented Nov 18, 2015

Uh oh!

tseaver commented Nov 19, 2015

Uh oh!

dhermes commented Nov 19, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants