Skip to content

Using custom named temporary file. - #1222

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-namedtemp
Nov 18, 2015
Merged

Using custom named temporary file.#1222
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-namedtemp

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

This is so that tests can run successfully on Windows.

In addition, using generic integer types (from six) for gcloud._helpers._millis_from_datetime since it returns a long on Windows and int on Linux. Also monkey patching the GCE ID check in test_ctor_w_dataset_id_no_environ since some CI environments will give a "false positive" on that test.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This is so that tests can run successfully on Windows.
In addition, using generic integer types (from `six`)
for `gcloud._helpers._millis_from_datetime` since it returns
a `long` on Windows and `int` on Linux. Also monkey
patching the GCE ID check in `test_ctor_w_dataset_id_no_environ`
since some CI environments will give a "false positive"
on that test.
@tseaver

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Nov 18, 2015
@dhermes
dhermes merged commit 1d1c8a2 into googleapis:masterNov 18, 2015
@dhermes
dhermes deleted the drop-namedtemp branch November 18, 2015 20:29
@dhermesdhermes mentioned this pull request Jan 25, 2016
@dhermesdhermes mentioned this pull request Jun 17, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat:adding emulator
* apb_feature_bq_emulator_test
* apb_feature_bq_emulator_variable_name_change
* abecerrilsalas_feature_bq_emulator_typo_changes
* feat:fixing var names and start of test
* abecerrilsalas_feature_additional_tests
* feat: testing update
* feat: fixed failed lint test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot