Skip to content

feat(spanner): add asynchronous code snippets and minor cleanup changes - #17337

Merged
sinhasubham merged 3 commits into
mainfrom
minor_cleanup_vlnr
Jun 2, 2026
Merged

feat(spanner): add asynchronous code snippets and minor cleanup changes#17337
sinhasubham merged 3 commits into
mainfrom
minor_cleanup_vlnr

Conversation

@sinhasubham

@sinhasubhamsinhasubham commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

  1. Partition Deserialization Simplification
    Addressing post merge minor comments from: fix(spanner_dbapi): replace insecure pickle with json for partition deserialization #17014

  2. Asynchronous Code Snippets & Integration Tests
    New Async Samples (async_snippets.py): Added standard asynchronous code snippets.
    New Integration Tests (async_snippets_test.py): Introduced integration tests using pytest-asyncio to sequentially execute and assert the output of all five asynchronous code snippets against a mock/live instance.

@sinhasubham
refactor(spanner_dbapi): simplify partition query parameter deseriali…
e3caf83
…zation
Simplify query parameter unpacking inside partition_helper.py by using Protobuf's MessageToDict helper directly on the Struct message instead of a custom recursive unpacker. Also update copyright year nits across modified files.
@sinhasubham
feat(spanner): add asynchronous code snippets and integration tests
a456523
Introduce a comprehensive set of asynchronous code samples inside samples/samples/async_snippets.py showcasing how to use AsyncClient, execute async queries, and run async read-write/read-only transactions. Add async_snippets_test.py to verify their end-to-end functionality.
@sinhasubhamsinhasubham changed the title Minor cleanup vlnrfeat(spanner): add asynchronous code snippets and minor cleanup changesJun 2, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 2, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces a custom protobuf unpacking function with MessageToDict in partition_helper.py and introduces new asynchronous snippets and tests for Cloud Spanner. A critical issue was identified in partition_helper.py where MessageToDict is used without being imported, which will cause a NameError at runtime.

Comment threadpackages/google-cloud-spanner/google/cloud/spanner_dbapi/partition_helper.py
@sinhasubham
sinhasubham marked this pull request as ready for review June 2, 2026 11:44
@sinhasubham
sinhasubham requested a review from a team as a code ownerJune 2, 2026 11:44
@snippet-bot

snippet-botBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

rahul2393
rahul2393 reviewed Jun 2, 2026
View reviewed changes
Comment threadpackages/google-cloud-spanner/tests/mockserver_tests/test_dbapi_partition_query.py
@@ -1,5 +1,5 @@
# Copyright 2024 Google LLC All rights reserved.
#
# Copyright 2026 Google LLC All rights reserved.

@rahul2393rahul2393Jun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see both 2024 and 2026 here is it intended?

@sinhasubhamsinhasubhamJun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no its not intended, missed to remove 2024. updated

@sinhasubham
style(spanner): update copyright year to 2026 for new test files
8823069
Update copyright headers in test_dbapi_partition_query.py and test_partition_helper.py to exactly 2026, since both are brand new files created in this PR. This resolves reviewer feedback.
@sinhasubham
sinhasubham merged commit d6aaf61 into mainJun 2, 2026
32 checks passed
@sinhasubham
sinhasubham deleted the minor_cleanup_vlnr branch June 2, 2026 13:05
@sofislsofisl mentioned this pull request Jun 11, 2026
Merged
sofisl added a commit that referenced this pull request Jun 11, 2026
@sofisl
chore: librarian release pull request: 20260611T192009Z (#17432)
6547012
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>gapic-generator: v1.35.0</summary>
##
[v1.35.0](gapic-generator-v1.34.1...gapic-generator-v1.35.0)
(2026-06-11)
### Features
* setup.py matches prerelease versions (#17370)
([25b857e](25b857e1))
### Bug Fixes
* require protobuf 6.33.5 to address CVE-2026-0994 (#17349)
([6642263](66422636))
</details>
<details><summary>google-auth: v2.54.0</summary>
##
[v2.54.0](google-auth-v2.53.0...google-auth-v2.54.0)
(2026-06-11)
### Features
* implement regional access boundary support for standalone JWT and
async service accounts (#17025)
([35af616](35af6168))
### Bug Fixes
* configure mTLS for impersonated credentials (#17404)
([57269d5](57269d56))
* fail-fast on missing ECP config file to avoid 30s hang (#17377)
([e096127](e0961270))
* Rename the &#39;seed&#39; argument for setting an initial regional
access boundary for clarity (#17186)
([e5c8cf9](e5c8cf92))
* update incorrect urls in setup.py to point at monorepo vs splitrepo
(#17237)
([eaed04b](eaed04ba))
</details>
<details><summary>google-cloud-alloydb: v0.11.0</summary>
##
[v0.11.0](google-cloud-alloydb-v0.10.0...google-cloud-alloydb-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-biglake: v0.5.0</summary>
##
[v0.5.0](google-cloud-biglake-v0.4.0...google-cloud-biglake-v0.5.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-ces: v0.7.0</summary>
##
[v0.7.0](google-cloud-ces-v0.6.0...google-cloud-ces-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-confidentialcomputing: v0.11.0</summary>
##
[v0.11.0](google-cloud-confidentialcomputing-v0.10.0...google-cloud-confidentialcomputing-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-modelarmor: v0.7.0</summary>
##
[v0.7.0](google-cloud-modelarmor-v0.6.0...google-cloud-modelarmor-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-network-services: v0.10.0</summary>
##
[v0.10.0](google-cloud-network-services-v0.9.0...google-cloud-network-services-v0.10.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-oracledatabase: v0.6.0</summary>
##
[v0.6.0](google-cloud-oracledatabase-v0.5.0...google-cloud-oracledatabase-v0.6.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-spanner: v3.68.0</summary>
##
[v3.68.0](google-cloud-spanner-v3.67.0...google-cloud-spanner-v3.68.0)
(2026-06-11)
### Features
* add asynchronous code snippets and minor cleanup changes (#17337)
([d6aaf61](d6aaf610))
### Performance Improvements
* optimize query result decoding (#17375)
([3f70b2f](3f70b2ff))
</details>
<details><summary>google-cloud-storage: v3.12.0</summary>
##
[v3.12.0](google-cloud-storage-v3.11.0...google-cloud-storage-v3.12.0)
(2026-06-11)
### Features
* full object checksum: implement rolling checksum and verification in
reads resumption strategy (#17262)
([2361ba6](2361ba6e))
* Enable full object checksum PR 1/3 : parse finalize_time and server
crc32c in async object stream (#17261)
([72c7a27](72c7a272))
* full object checksum: integrate full-object checksum in
AsyncMultiRangeDownloader (#17263)
([b6a85e4](b6a85e49))
</details>
<details><summary>google-developer-knowledge: v0.1.0</summary>
##
[v0.1.0](google-developer-knowledge-v0.0.0...google-developer-knowledge-v0.1.0)
(2026-06-11)
### Features
* add google-developer-knowledge (#17417)
([ca02afc](ca02afce))
</details>
This was referenced Jun 23, 2026
Closed
Closed
chalmerlowe pushed a commit that referenced this pull request Jun 25, 2026
@sofisl@chalmerlowe
chore: librarian release pull request: 20260611T192009Z (#17432)
e020cbc
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>gapic-generator: v1.35.0</summary>
##
[v1.35.0](gapic-generator-v1.34.1...gapic-generator-v1.35.0)
(2026-06-11)
### Features
* setup.py matches prerelease versions (#17370)
([25b857e](25b857e1))
### Bug Fixes
* require protobuf 6.33.5 to address CVE-2026-0994 (#17349)
([6642263](66422636))
</details>
<details><summary>google-auth: v2.54.0</summary>
##
[v2.54.0](google-auth-v2.53.0...google-auth-v2.54.0)
(2026-06-11)
### Features
* implement regional access boundary support for standalone JWT and
async service accounts (#17025)
([35af616](35af6168))
### Bug Fixes
* configure mTLS for impersonated credentials (#17404)
([57269d5](57269d56))
* fail-fast on missing ECP config file to avoid 30s hang (#17377)
([e096127](e0961270))
* Rename the &#39;seed&#39; argument for setting an initial regional
access boundary for clarity (#17186)
([e5c8cf9](e5c8cf92))
* update incorrect urls in setup.py to point at monorepo vs splitrepo
(#17237)
([eaed04b](eaed04ba))
</details>
<details><summary>google-cloud-alloydb: v0.11.0</summary>
##
[v0.11.0](google-cloud-alloydb-v0.10.0...google-cloud-alloydb-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-biglake: v0.5.0</summary>
##
[v0.5.0](google-cloud-biglake-v0.4.0...google-cloud-biglake-v0.5.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-ces: v0.7.0</summary>
##
[v0.7.0](google-cloud-ces-v0.6.0...google-cloud-ces-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-confidentialcomputing: v0.11.0</summary>
##
[v0.11.0](google-cloud-confidentialcomputing-v0.10.0...google-cloud-confidentialcomputing-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-modelarmor: v0.7.0</summary>
##
[v0.7.0](google-cloud-modelarmor-v0.6.0...google-cloud-modelarmor-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-network-services: v0.10.0</summary>
##
[v0.10.0](google-cloud-network-services-v0.9.0...google-cloud-network-services-v0.10.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-oracledatabase: v0.6.0</summary>
##
[v0.6.0](google-cloud-oracledatabase-v0.5.0...google-cloud-oracledatabase-v0.6.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-spanner: v3.68.0</summary>
##
[v3.68.0](google-cloud-spanner-v3.67.0...google-cloud-spanner-v3.68.0)
(2026-06-11)
### Features
* add asynchronous code snippets and minor cleanup changes (#17337)
([d6aaf61](d6aaf610))
### Performance Improvements
* optimize query result decoding (#17375)
([3f70b2f](3f70b2ff))
</details>
<details><summary>google-cloud-storage: v3.12.0</summary>
##
[v3.12.0](google-cloud-storage-v3.11.0...google-cloud-storage-v3.12.0)
(2026-06-11)
### Features
* full object checksum: implement rolling checksum and verification in
reads resumption strategy (#17262)
([2361ba6](2361ba6e))
* Enable full object checksum PR 1/3 : parse finalize_time and server
crc32c in async object stream (#17261)
([72c7a27](72c7a272))
* full object checksum: integrate full-object checksum in
AsyncMultiRangeDownloader (#17263)
([b6a85e4](b6a85e49))
</details>
<details><summary>google-developer-knowledge: v0.1.0</summary>
##
[v0.1.0](google-developer-knowledge-v0.0.0...google-developer-knowledge-v0.1.0)
(2026-06-11)
### Features
* add google-developer-knowledge (#17417)
([ca02afc](ca02afce))
</details>
@release-pleaserelease-pleaseBot mentioned this pull request Jul 15, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393rahul2393rahul2393 approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sinhasubham@rahul2393