Skip to content

feat(gapic-generator-python): setup.py matches prereleases - #17370

Merged
noahdietz merged 2 commits into
googleapis:mainfrom
noahdietz:ggp-version-matcher
Jun 4, 2026
Merged

feat(gapic-generator-python): setup.py matches prereleases#17370
noahdietz merged 2 commits into
googleapis:mainfrom
noahdietz:ggp-version-matcher

Conversation

@noahdietz

@noahdietznoahdietz commented Jun 3, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Expand the version_candidates matching regex in setup.py to support SemVer prerelease suffixes.

To support both SemVer and PEP 440 prerelease formats robustly, we can match any trailing non-quote, non-whitespace characters after the major.minor.patch version.

Regenerated one API and opened a PR to see checks passing.

Towards googleapis/librarian#6289

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 3, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the regular expression used to parse version strings in setup.py templates and golden files to support prerelease suffixes. The reviewer notes that the proposed regex strictly expects a hyphen for prerelease versions, which would fail for PEP 440 compliant versions without a hyphen (such as 1.0.0a1). To prevent installation crashes, the reviewer suggests a more robust regex that matches any trailing non-quote, non-whitespace characters after the patch version.

Comment threadpackages/gapic-generator/gapic/templates/setup.py.j2
Comment threadpackages/gapic-generator/tests/integration/goldens/asset/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/credentials/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/eventarc/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/logging/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/logging_internal/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/redis/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/redis_selective/setup.py
Comment threadpackages/gapic-generator/tests/integration/goldens/storagebatchoperations/setup.py
@noahdietz
noahdietz marked this pull request as ready for review June 4, 2026 22:01
@noahdietz
noahdietz requested a review from a team as a code ownerJune 4, 2026 22:02
@noahdietz
noahdietz merged commit 25b857e into googleapis:mainJun 4, 2026
90 checks passed
@noahdietz
noahdietz deleted the ggp-version-matcher branch June 4, 2026 22:16
@sofislsofisl mentioned this pull request Jun 11, 2026
Merged
sofisl added a commit that referenced this pull request Jun 11, 2026
@sofisl
chore: librarian release pull request: 20260611T192009Z (#17432)
6547012
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>gapic-generator: v1.35.0</summary>
##
[v1.35.0](gapic-generator-v1.34.1...gapic-generator-v1.35.0)
(2026-06-11)
### Features
* setup.py matches prerelease versions (#17370)
([25b857e](25b857e1))
### Bug Fixes
* require protobuf 6.33.5 to address CVE-2026-0994 (#17349)
([6642263](66422636))
</details>
<details><summary>google-auth: v2.54.0</summary>
##
[v2.54.0](google-auth-v2.53.0...google-auth-v2.54.0)
(2026-06-11)
### Features
* implement regional access boundary support for standalone JWT and
async service accounts (#17025)
([35af616](35af6168))
### Bug Fixes
* configure mTLS for impersonated credentials (#17404)
([57269d5](57269d56))
* fail-fast on missing ECP config file to avoid 30s hang (#17377)
([e096127](e0961270))
* Rename the &#39;seed&#39; argument for setting an initial regional
access boundary for clarity (#17186)
([e5c8cf9](e5c8cf92))
* update incorrect urls in setup.py to point at monorepo vs splitrepo
(#17237)
([eaed04b](eaed04ba))
</details>
<details><summary>google-cloud-alloydb: v0.11.0</summary>
##
[v0.11.0](google-cloud-alloydb-v0.10.0...google-cloud-alloydb-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-biglake: v0.5.0</summary>
##
[v0.5.0](google-cloud-biglake-v0.4.0...google-cloud-biglake-v0.5.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-ces: v0.7.0</summary>
##
[v0.7.0](google-cloud-ces-v0.6.0...google-cloud-ces-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-confidentialcomputing: v0.11.0</summary>
##
[v0.11.0](google-cloud-confidentialcomputing-v0.10.0...google-cloud-confidentialcomputing-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-modelarmor: v0.7.0</summary>
##
[v0.7.0](google-cloud-modelarmor-v0.6.0...google-cloud-modelarmor-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-network-services: v0.10.0</summary>
##
[v0.10.0](google-cloud-network-services-v0.9.0...google-cloud-network-services-v0.10.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-oracledatabase: v0.6.0</summary>
##
[v0.6.0](google-cloud-oracledatabase-v0.5.0...google-cloud-oracledatabase-v0.6.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-spanner: v3.68.0</summary>
##
[v3.68.0](google-cloud-spanner-v3.67.0...google-cloud-spanner-v3.68.0)
(2026-06-11)
### Features
* add asynchronous code snippets and minor cleanup changes (#17337)
([d6aaf61](d6aaf610))
### Performance Improvements
* optimize query result decoding (#17375)
([3f70b2f](3f70b2ff))
</details>
<details><summary>google-cloud-storage: v3.12.0</summary>
##
[v3.12.0](google-cloud-storage-v3.11.0...google-cloud-storage-v3.12.0)
(2026-06-11)
### Features
* full object checksum: implement rolling checksum and verification in
reads resumption strategy (#17262)
([2361ba6](2361ba6e))
* Enable full object checksum PR 1/3 : parse finalize_time and server
crc32c in async object stream (#17261)
([72c7a27](72c7a272))
* full object checksum: integrate full-object checksum in
AsyncMultiRangeDownloader (#17263)
([b6a85e4](b6a85e49))
</details>
<details><summary>google-developer-knowledge: v0.1.0</summary>
##
[v0.1.0](google-developer-knowledge-v0.0.0...google-developer-knowledge-v0.1.0)
(2026-06-11)
### Features
* add google-developer-knowledge (#17417)
([ca02afc](ca02afce))
</details>
chalmerlowe pushed a commit that referenced this pull request Jun 25, 2026
@sofisl@chalmerlowe
chore: librarian release pull request: 20260611T192009Z (#17432)
e020cbc
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>gapic-generator: v1.35.0</summary>
##
[v1.35.0](gapic-generator-v1.34.1...gapic-generator-v1.35.0)
(2026-06-11)
### Features
* setup.py matches prerelease versions (#17370)
([25b857e](25b857e1))
### Bug Fixes
* require protobuf 6.33.5 to address CVE-2026-0994 (#17349)
([6642263](66422636))
</details>
<details><summary>google-auth: v2.54.0</summary>
##
[v2.54.0](google-auth-v2.53.0...google-auth-v2.54.0)
(2026-06-11)
### Features
* implement regional access boundary support for standalone JWT and
async service accounts (#17025)
([35af616](35af6168))
### Bug Fixes
* configure mTLS for impersonated credentials (#17404)
([57269d5](57269d56))
* fail-fast on missing ECP config file to avoid 30s hang (#17377)
([e096127](e0961270))
* Rename the &#39;seed&#39; argument for setting an initial regional
access boundary for clarity (#17186)
([e5c8cf9](e5c8cf92))
* update incorrect urls in setup.py to point at monorepo vs splitrepo
(#17237)
([eaed04b](eaed04ba))
</details>
<details><summary>google-cloud-alloydb: v0.11.0</summary>
##
[v0.11.0](google-cloud-alloydb-v0.10.0...google-cloud-alloydb-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-biglake: v0.5.0</summary>
##
[v0.5.0](google-cloud-biglake-v0.4.0...google-cloud-biglake-v0.5.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-ces: v0.7.0</summary>
##
[v0.7.0](google-cloud-ces-v0.6.0...google-cloud-ces-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-confidentialcomputing: v0.11.0</summary>
##
[v0.11.0](google-cloud-confidentialcomputing-v0.10.0...google-cloud-confidentialcomputing-v0.11.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-modelarmor: v0.7.0</summary>
##
[v0.7.0](google-cloud-modelarmor-v0.6.0...google-cloud-modelarmor-v0.7.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-network-services: v0.10.0</summary>
##
[v0.10.0](google-cloud-network-services-v0.9.0...google-cloud-network-services-v0.10.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17431)
([2e75c78](2e75c78c))
</details>
<details><summary>google-cloud-oracledatabase: v0.6.0</summary>
##
[v0.6.0](google-cloud-oracledatabase-v0.5.0...google-cloud-oracledatabase-v0.6.0)
(2026-06-11)
### Features
* update API sources and regenerate (#17413)
([59fe7cf](59fe7cf8))
</details>
<details><summary>google-cloud-spanner: v3.68.0</summary>
##
[v3.68.0](google-cloud-spanner-v3.67.0...google-cloud-spanner-v3.68.0)
(2026-06-11)
### Features
* add asynchronous code snippets and minor cleanup changes (#17337)
([d6aaf61](d6aaf610))
### Performance Improvements
* optimize query result decoding (#17375)
([3f70b2f](3f70b2ff))
</details>
<details><summary>google-cloud-storage: v3.12.0</summary>
##
[v3.12.0](google-cloud-storage-v3.11.0...google-cloud-storage-v3.12.0)
(2026-06-11)
### Features
* full object checksum: implement rolling checksum and verification in
reads resumption strategy (#17262)
([2361ba6](2361ba6e))
* Enable full object checksum PR 1/3 : parse finalize_time and server
crc32c in async object stream (#17261)
([72c7a27](72c7a272))
* full object checksum: integrate full-object checksum in
AsyncMultiRangeDownloader (#17263)
([b6a85e4](b6a85e49))
</details>
<details><summary>google-developer-knowledge: v0.1.0</summary>
##
[v0.1.0](google-developer-knowledge-v0.0.0...google-developer-knowledge-v0.1.0)
(2026-06-11)
### Features
* add google-developer-knowledge (#17417)
([ca02afc](ca02afce))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanchedaniel-sanchedaniel-sanche approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noahdietz@daniel-sanche