Skip to content

Add BigQuery UDF support - #1988

Closed
takbab wants to merge 28 commits into
googleapis:masterfrom
takbab:feature-bigquery-udf
Closed

Add BigQuery UDF support#1988
takbab wants to merge 28 commits into
googleapis:masterfrom
takbab:feature-bigquery-udf

Conversation

@takbab

@takbabtakbab commented Jul 16, 2016•
edited by tseaver
Loading

Copy link
Copy Markdown

Add a field to support BigQuery UDF.
https://cloud.google.com/bigquery/docs/reference/v2/jobs

  • configuration.query.userDefinedFunctionResources[]
  • configuration.query.userDefinedFunctionResources[].inlineCode
  • configuration.query.userDefinedFunctionResources[].resourceUri

Closes#1829

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2016
@tseavertseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Jul 16, 2016
tseaver
tseaver reviewed Jul 16, 2016
View reviewed changes
Comment threadgcloud/bigquery/job.py
user_defined_function_resources = _TypedProperty('user_defined_function_resources', list)
"""See:
https://cloud.google.com/bigquery/docs/reference/v2/jobs#configuration.query.userDefinedFunctionResources
"""

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Jul 16, 2016

Copy link
Copy Markdown
Contributor

@takbab Thanks for pitching in on this feature!

@takbab

takbab commented Jul 16, 2016

Copy link
Copy Markdown
Author

@tseaver Thanks for checking!

tseaver
tseaver reviewed Jul 16, 2016
View reviewed changes
Comment threadgcloud/bigquery/job.py Outdated
_flatten_results = None
_priority = None
_use_query_cache = None
_user_defined_function_resources = None

This comment was marked as spam.

Sign in to view

tseaverand others added 8 commits July 18, 2016 12:03
@tseaver
pylint 1.6.3 complains about not calling .
b602d18
@tseaver
Bump minimum pylint version to 1.6.3.
cdf2e37
Allow it to check files that cause 1.6.0 to barf.
@tseaver
Merge pull requestgoogleapis#1990from tseaver/pylint-1.6.3-compat
df47b57
Pylint 1.6.3 compatibility
@dhermes
Adding BigQuery support for legacy SQL.
21ae0c9
Fixesgoogleapis#1607.
@tseaver
Fix branch coverage miss in 'gcloud.streaming.transfer'.
eacccab
Introduced in PR googleapis#1914.
Bump pylint's max line count for test modules accordingly.
@tseaver
Merge pull requestgoogleapis#1994from tseaver/1914-fix-branch-miss-…
e653b95
…coveralls-saddenz
Fix branch coverage miss in 'gcloud.streaming.transfer'.
@dhermes
Merge pull requestgoogleapis#1992from dhermes/fix-1607
d171791
Adding BigQuery support for legacy SQL.
UU085905
changed attribute name. pylint wants a max of 30 chars.
d3dcfcc
@googlebot

googlebot commented Jul 19, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 19, 2016
@tseaver

tseaver commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

@takbab The e-mail address associated with commit d3dcfcc is not recognized by Github as belonging to your account, and therefore the CLA bot is flagging that commit.

@dhermes
PEP257 Clean-up of docstrings.
a54d078
Fixes all Pylint failures of
- missing-returns-doc
- redundant-returns-doc
- ungrouped-imports
Also makes a little headway on missing-raises-doc though it's
unclear if this error should be fixed.
Towards googleapis#1968.
@dhermes
Removing catching-non-exception from pylint disable.
8ee5e03
This is because the false positive was fixed in Pylint
1.6.4.
@dhermes
Making HappyBase enabled/disabled checks into no-ops.
6bd2442
Fixesgoogleapis#1989.
@dhermes
Making HappyBase compact_table() a no-op.
699c027
Also fixing some lint related errors (not using arguments
and not using self).
@dhermes
Fixing language about HappyBase table compaction.
0cb6e60
dhermesand others added 12 commits July 19, 2016 13:07
@dhermes
Merge pull requestgoogleapis#1997from dhermes/fix-1989
24c4358
Making HappyBase enabled/disabled checks into no-ops.
@dhermes
Emulating HappyBase in counter_set.
08aeba1
Note this is "broken" in some sense though matches the
semantics of the original.
@dhermes
Updating docs for differences of HappyBase.
22dd5e8
@dhermes
Merge pull requestgoogleapis#1996from dhermes/partial-revert-1974
8f3469c
PEP257 Clean-up of docstrings.
@dhermes
Merge pull requestgoogleapis#2000from dhermes/counter_set-happybase…
e0addef
…-just-put
Make counter_set in HappyBase agree with HBase impl. semantics
@daspecster
Fix datastore __init__ docstring.
a50936d
@daspecster
Merge pull requestgoogleapis#2005from daspecster/fix-datastore-init…
b213cb8
…-doc
Fix datastore __init__ docstring.
@takbabUU085905
Add configuration.query.userDefinedFunctionResources to bigquery.jobs.
9374f5b
@takbabUU085905
wrap to < 79 characters for PEP8
516899c
UU085905
changed attribute name. pylint wants a max of 30 chars.
4075bb8
UU085905
corrected.
34485f6
@takbab
Merge remote-tracking branch 'origin/feature-bigquery-udf' into featu…
dabf186
…re-bigquery-udf
# Conflicts:
#	gcloud/bigquery/job.py
#	gcloud/bigquery/test_job.py
@googlebot

googlebot commented Jul 20, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@takbabtakbab changed the title Add configuration.query.userDefinedFunctionResources to bigquery.jobs.Add BigQuery UDF supportJul 21, 2016
@takbab

takbab commented Jul 21, 2016

Copy link
Copy Markdown
Author

@tseaver I will recreate PR to clean my commits and diff.

@takbabtakbab closed this Jul 21, 2016
@takbab
takbab deleted the feature-bigquery-udf branch July 21, 2016 01:14
@takbabtakbab mentioned this pull request Jul 21, 2016
Closed
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
feat: Add level, inplace params to reset_index (#1988)
d9c19d9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseavertseaver

Labels

api: bigqueryIssues related to the BigQuery API.cla: noThis human has *not* signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@takbab@tseaver@googlebot@mbrukman@dhermes@daspecster