Skip to content

Add Vision API connection. - #2167

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-connection
Aug 23, 2016
Merged

Add Vision API connection.#2167
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-connection

Conversation

@daspecster

@daspecsterdaspecster commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

As per a conversation about small PR's with @dhermes, here is Vision's connection class.

This is pretty simple, just adding the needed scope.

@daspecsterdaspecster added the api: vision Issues related to the Cloud Vision API. label Aug 23, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Looks fine but Travis is failing.

dhermes
dhermes reviewed Aug 23, 2016
View reviewed changes
Comment threadgcloud/vision/connection.py
API_VERSION = 'v1'
"""The version of the API, used in building the API call's URL."""

API_URL_TEMPLATE = '{api_base_url}/{api_version}{path}'

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

It was failing, I believe because I didn't have the RST for it in there. Also I added an API URL example. https://vision.googleapis.com/v1/images:annotate

dhermes
dhermes reviewed Aug 23, 2016
View reviewed changes
Comment threadscripts/generate_json_docs.py Outdated
'streaming': [],
'translate': []
'translate': [],
'vision': []

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

LGTM once Travis passes though you should squash if not too inconvenient

@dhermesdhermes mentioned this pull request Aug 23, 2016
Merged
@daspecster

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Wow travis...what's the deal?

@tseaver

tseaver commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

@daspecster I'm guessing the conflict is in docs/json/json/master/toc.json, after @dhermes merged #2171.

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Yeah Travis has been slow. And in the 35 minutes since you posted that, I did give you a conflict. Sorry.

@daspecster
Add Vision API connection.
2cf3a90
Add RST and ignore vision.__init__.
Add API URL example.
Add vision to TOCs.
Add trailing comma.
Add vision/connection to toc.json.
@dhermesdhermes mentioned this pull request Aug 23, 2016
Merged
@daspecster

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Conflict resolved....back to waiting on travis.

@daspecster
daspecster merged commit d64c9c3 into googleapis:masterAug 23, 2016
@daspecster

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Finally!

@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster
daspecster deleted the vision-connection branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Mar 6, 2026
@tswast
fix: query() now warns when job_id is set and the default `job_re…
5c560b9
…try` is ignored (#2167)
* fix: `query()` now warns when `job_id` is set and the default `job_retry` is ignored
* Update google/cloud/bigquery/client.py
* allow None for job_retry in code path that calls jobs.query from client.query
* allow None for job_retry in code path that calls jobs.query from client.query
* Update tests/unit/test_job_retry.py
parthea pushed a commit that referenced this pull request Apr 1, 2026
@release-please
chore(main): release 2.26.0 (#2167)
dd1e98a
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseavertseaver

Labels

api: visionIssues related to the Cloud Vision API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster@dhermes@tseaver@googlebot