Skip to content

Make handwritten JSON documents more uniform - #2171

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-toc-json
Aug 23, 2016
Merged

Make handwritten JSON documents more uniform#2171
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-toc-json

Conversation

@dhermes

@dhermesdhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Also

  • removing no longer needed toc-all.json
  • removing a section of toc.json in exceptions that didn't belong

Used the following script to update the content:

importjsonfiles= [
'docs/json/json/master/index.json',
'docs/json/json/master/toc.json',
'docs/json/manifest.json',
]
forfilenameinfiles:
withopen(filename, 'rb') asfile_obj:
content=json.load(file_obj)
withopen(filename, 'wb') asfile_obj:
json.dump(content, file_obj, indent=2, sort_keys=True,
separators=(',', ': ')) # Added separators laterfile_obj.write('\n') # Added later

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@tseavertseaver mentioned this pull request Aug 23, 2016
@daspecster

Copy link
Copy Markdown
Contributor

LGTM

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@daspecster This will also break #2167, so I'll hold off on merging until you get it in 😉

Ping me though so I don't forget?

@daspecster

Copy link
Copy Markdown
Contributor

Ok yeah, just waiting on travis again... ⏳

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Just rebased after #2167. Note that I added a newline to the end of each JSON file and also used custom json separators since by default a trailing space is used after the comma separator.

@daspecster

Copy link
Copy Markdown
Contributor

LGTM.

@dhermes
dhermes merged commit 94c2743 into googleapis:masterAug 23, 2016
@dhermes
dhermes deleted the update-toc-json branch August 23, 2016 22:37
@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Mar 6, 2026
#2171)
* Add ability to set autodetect_schema query_param
* fixup! Add ability to set autodetect_schema query_param
* fixup! Add ability to set autodetect_schema query_param
* fixup! Add ability to set autodetect_schema query_param
---------
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: Add cleanup step for old UDFs in anonymous dataset
* fix
* fix
* fix with some test code
* fix
* no retry
* fix retry
* disable doctest
* testing - increase timeout
* revert timout
* add warning
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@daspecster@googlebot