Uh oh!
There was an error while loading. Please reload this page.
Move storage code into a subpackage - #2416
Conversation
theacodes
left a comment
There was a problem hiding this comment.
LGTM with a few tiny things.
| bucket = client.get_bucket('bucket-id-here') | ||
| # Then do other things... | ||
| blob = bucket.get_blob('remote/path/to/file.txt') | ||
| print blob.download_as_string() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
| --cov-append \ | ||
| --cov-config {toxinidir}/.coveragerc \ | ||
| core/unit_tests | ||
| py.test --quiet \ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dd9c52e to
9af414dComparetheacodes
commented
Sep 26, 2016
LGTM |
tseaver
commented
Sep 26, 2016
|
dhermes
commented
Sep 26, 2016
@tseaver Yes essentially all will conflict, but luckily I can just re-run the script (that is why I ran it).
|
tseaver
commented
Sep 26, 2016
OK, LGTM |
Done via: $ mkdir -p storage/google/cloud $ cp google/__init__.py storage/google/__init__.py $ git add storage/google/__init__.py $ cp google/cloud/__init__.py storage/google/cloud/__init__.py $ git add storage/google/cloud/__init__.py $ git mv google/cloud/storage storage/google/cloud/storage $ git mv unit_tests/storage storage/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-storage as a dependency to the umbrella
package
- Adding the storage subdirectory into the list of packages
for verifying the docs
- Incorporating the storage subdirectory into the umbrella
coverage report
- Adding the storage only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the storage
tox config9af414d to
b01ffb4Comparedhermes
commented
Sep 26, 2016
Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful. |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3