Skip to content

Move datastore code into a subpackage - #2417

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:make-datastore-subpackage
Sep 26, 2016
Merged

Move datastore code into a subpackage#2417
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:make-datastore-subpackage

Conversation

@dhermes

@dhermesdhermes commented Sep 25, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-datastore-subpackage ../hotfix official/master
python make_commits.py \
--git-root "${PROJECT_DIR}/../hotfix" \
--package datastore \
--package-name "Google Cloud Datastore" \
--readme "${READMES_DIR}/datastore/README.rst" \
--extra-requires $' \'grpcio >= 1.0.0\',\n' \
--maybe-omit $'omit =\n */_generated/*.py\n'

NOTE: Since only bigtable and datastore had to touch the run_pylint and tox.ini configs for ignoring generated code, the 3rd commit is just written the old-fashioned way.

@dhermesdhermes added api: datastore Issues related to the Datastore API. packaging labels Sep 25, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2016
@dhermesdhermes mentioned this pull request Sep 25, 2016
Closed
32 tasks
theacodes
theacodes approved these changes Sep 25, 2016
View reviewed changes
Comment threaddatastore/setup.py

REQUIREMENTS = [
'google-cloud-core',
'grpcio >= 1.0.0',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaddatastore/setup.py


REQUIREMENTS = [
'google-cloud-core',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermesdhermes mentioned this pull request Sep 26, 2016
Merged
@dhermes
dhermesforce-pushed the make-datastore-subpackage branch from e98911b to 5cc0b29CompareSeptember 26, 2016 17:24
daspecster
daspecster reviewed Sep 26, 2016
View reviewed changes
Comment thread.travis.yml
- tox -e lint
- tox -e cover
- (cd core && tox -e cover)
- (cd datastore && tox -e cover)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
Moving all datastore files into subdirectory.
5050282
Done via:
$ mkdir -p datastore/google/cloud
$ cp google/__init__.py datastore/google/__init__.py
$ git add datastore/google/__init__.py
$ cp google/cloud/__init__.py datastore/google/cloud/__init__.py
$ git add datastore/google/cloud/__init__.py
$ git mv google/cloud/datastore datastore/google/cloud/datastore
$ git mv unit_tests/datastore datastore/unit_tests
@dhermes
Making datastore subpackage into a proper package.
115f86e
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-datastore as a dependency to the umbrella
package
- Adding the datastore subdirectory into the list of packages
for verifying the docs
- Incorporating the datastore subdirectory into the umbrella
coverage report
- Adding the datastore only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the datastore
tox config
@dhermes
Adding extra ignores for datastore generated files.
0401983
@dhermes
dhermesforce-pushed the make-datastore-subpackage branch from 5cc0b29 to 0401983CompareSeptember 26, 2016 19:41
@dhermes

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
ContributorAuthor

As with #2416, Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful.

@dhermes
dhermes merged commit 59f234b into googleapis:masterSep 26, 2016
@dhermes
dhermes deleted the make-datastore-subpackage branch September 26, 2016 19:42
This was referenced Sep 26, 2016
Merged
Merged
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
feat: add bigframes.pandas.options.experiments.sql_compiler for swi…
d127a8b
…tching the backend compiler (#2417)
This change adds `bigframes.pandas.options.experiments.sql_compiler` to
allow switching the backend compiler. Currently, the default remains set
to 'legacy' (ibis), but users can now optionally switch to the
'experimental' (sqlglot) compiler.
Fixes internal issue 479912001🦕
parthea pushed a commit that referenced this pull request Apr 1, 2026
@shuoweil
chore: librarian release pull request:20260202T232430Z (#2428)
a9a935f
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
<details><summary>bigframes: 2.34.0</summary>
##
[2.34.0](google/bigframes@v2.33.0...v2.34.0)
(2026-02-02)
### Features
* add `bigframes.pandas.options.experiments.sql_compiler` for switching
the backend compiler (#2417)
([7eba6ee03f07938315d99e2aeaf72368c02074cf](google/bigframes@7eba6ee))
* add bigquery.ml.generate_embedding function (#2422)
([35f3f5e6f8c64b47e6e7214034f96f047785e647](google/bigframes@35f3f5e))
* add bigquery.create_external_table method (#2415)
([76db2956e505aec4f1055118ac7ca523facc10ff](google/bigframes@76db295))
* add deprecation warnings for .blob accessor and read_gbq_object_table
(#2408)
([7261a4ea5cdab6b30f5bc333501648c60e70be59](google/bigframes@7261a4e))
* add bigquery.ml.generate_text function (#2403)
([5ac681028624de15e31f0c2ae360b47b2dcf1e8d](google/bigframes@5ac6810))
### Bug Fixes
* broken job url (#2411)
([fcb5bc1761c656e1aec61dbcf96a36d436833b7a](google/bigframes@fcb5bc1))
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecsterdaspecsterdaspecster left review comments
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

@theacodestheacodes

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@tseaver@daspecster@theacodes@googlebot