Skip to content

#295 let entity save accept null value for attribute - #296

Merged
tseaver merged 3 commits into
googleapis:masterfrom
lucemia:support-null-value
Oct 28, 2014
Merged

#295 let entity save accept null value for attribute#296
tseaver merged 3 commits into
googleapis:masterfrom
lucemia:support-null-value

Conversation

@lucemia

Copy link
Copy Markdown
Contributor

#295

Has unit test

@lucemia

Copy link
Copy Markdown
ContributorAuthor

will still raise

/protobuf/internal/python_message.py in SerializeToString `api.services.datastore.CommitRequest is missing required fields: mutation.upsert[0].property[2].value` exception in protobuf

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 3753821 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 014b658 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

Comment threadgcloud/datastore/helpers.py Outdated

This comment was marked as spam.

This comment was marked as spam.

Comment threadgcloud/datastore/test_helpers.py Outdated

This comment was marked as spam.

@silvolusilvolu added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2014
@lucemia

Copy link
Copy Markdown
ContributorAuthor

@dhermes I didn't add NULL_PROPERTY = object() in current pull request yet because I think there are pros and cons to add sentinel value.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a208132 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM.

-1 on a sentinel: _set_protobuf_value() is not an API, it only gets values from those stored in Entities, and from the filter(expr, value) method of a Query: in both cases, None is the more Pythonic way to express what the user expects, and there is no notion of a "default".

@tseaver

Copy link
Copy Markdown
Contributor

Note that we already returnNone from _get_value_from_value_pb() in the case that none of the fields has been set.

tseaver added a commit that referenced this pull request Oct 28, 2014
#295 let entity save accept null value for attribute
@tseaver
tseaver merged commit 7d9bfb1 into googleapis:masterOct 28, 2014
@lucemia
lucemia deleted the support-null-value branch November 28, 2014 03:37
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Add Drive.get_item_by_path(item_path)
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 6, 2023
atulep pushed a commit that referenced this pull request Apr 6, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
…tage for the UploadConversation API when creating Analyses in Insights (#296)
* feat: add a way to specify the conversation automatic analysis percentage for the UploadConversation API when creating Analyses in Insights
PiperOrigin-RevId: 513416013
Source-Link: googleapis/googleapis@dacdbc8
Source-Link: googleapis/googleapis-gen@7e3cf93
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2UzY2Y5MzMwMDA0NWU5YTVjYmZiMTkwMDJkMWNkNGNiOTNiMDZkMCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea added a commit that referenced this pull request Jun 4, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
…296)
* feat: add cloud spanner connection properties - serverless analytics
feat: add cloud spanner connection properties - database role
PiperOrigin-RevId: 511807110
Source-Link: googleapis/googleapis@a563815
Source-Link: googleapis/googleapis-gen@a28f65a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTI4ZjY1YWNhY2UxMjUwNGRmZTQ0OGIyYmRjNTUxM2VlODk4NjI2NSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: Update gapic-generator-python to v1.8.5
PiperOrigin-RevId: 511892190
Source-Link: googleapis/googleapis@a45d9c0
Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: Fixed Ruby documentation generation
PiperOrigin-RevId: 512672271
Source-Link: googleapis/googleapis@bc22d91
Source-Link: googleapis/googleapis-gen@cad484d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2FkNDg0ZDRkYmRjNDM0YmFiOWJkZWIxN2NkZDA3ODQ1N2M3YzcwZCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
…[autoapprove] (#296)
Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea pushed a commit that referenced this pull request Sep 22, 2023
- [ ] Regenerate this pull request now.
docs: list oneofs in docstring
fix(deps): require google-api-core >= 1.28.0
fix(deps): drop packaging dependency
committer: busunkim96@
PiperOrigin-RevId: 406468269
Source-Link: googleapis/googleapis@83d81b0
Source-Link: googleapis/googleapis-gen@2ff001f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 413780624
Source-Link: googleapis/googleapis@ed9918e
Source-Link: googleapis/googleapis-gen@9286ba6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTI4NmJhNjBlMWMxZjZiY2Q1NTllOTgzNDc1NmIyZmEzZTUxZjI2ZCJ9
feat: added field for BigQuery inspect template inclusion lists feat: added field to support infotype versioning
parthea pushed a commit that referenced this pull request Sep 22, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/python-dlp/compare/v3.3.1...v3.4.0) (2021-12-03)
### Features
* added deidentify replacement dictionaries ([#296](https://www.github.com/googleapis/python-dlp/issues/296)) ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field for BigQuery inspect template inclusion lists ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field to support infotype versioning ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
…pprove] (#296)
Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
* chore: update Java and Python dependencies
PiperOrigin-RevId: 408420890
Source-Link: googleapis/googleapis@2921f9f
Source-Link: googleapis/googleapis-gen@6598ca8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
* feat: Add an enum value for raw locations from Apple platforms
PiperOrigin-RevId: 476961484
Source-Link: googleapis/googleapis@695134b
Source-Link: googleapis/googleapis-gen@49457f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDk0NTdmOWU3YWFlODljZmUwNDkxYWY0ZGJkOTk2MWE5MDEyNWQzMiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 22, 2023
parthea pushed a commit that referenced this pull request Jan 10, 2025
* chore: Update gapic-generator-python to v1.18.0
PiperOrigin-RevId: 638650618
Source-Link: googleapis/googleapis@6330f03
Source-Link: googleapis/googleapis-gen@44fa4f1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@71a7297
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
…296)
Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
In an overabundance of caution, we were deleting `cursor_after` from
QueryIterator after exhausting the iterator. This was found to differ
from the original implementation, however, and break some customer's
code.
Fixes#292
parthea pushed a commit that referenced this pull request Mar 2, 2026
parthea pushed a commit that referenced this pull request Mar 6, 2026
When retrying a transaction that failed, we MUST retry
every single prior statement as well as the current one,
until .commit() or .rollback() are invoked.
Fixes#285Fixes#296
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lucemia@coveralls@tseaver@dhermes@silvolu