Skip to content

Address #293: document that app code should not pass 'dataset_id' to 'Key.__init__'. - #297

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:293-clarify_key_datastore_id_parameter
Oct 28, 2014
Merged

Address #293: document that app code should not pass 'dataset_id' to 'Key.__init__'.#297
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:293-clarify_key_datastore_id_parameter

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Only the 'helpers.key_from_protobuf' factory should pass it.

Fixes#293.

Only the 'helpers.key_from_protobuf' factory should pass it.
Fixes#293.
Comment threadgcloud/datastore/key.py Outdated

This comment was marked as spam.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 720fdc9 on tseaver:293-clarify_key_datastore_id_parameter into f7d0441 on GoogleCloudPlatform:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a823baa on tseaver:293-clarify_key_datastore_id_parameter into f7d0441 on GoogleCloudPlatform:master.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request Oct 28, 2014
…ameter
Address #293: document that app code should not pass 'dataset_id' to 'Key.__init__'.
@tseaver
tseaver merged commit e1fd94f into googleapis:masterOct 28, 2014
@tseaver
tseaver deleted the 293-clarify_key_datastore_id_parameter branch October 28, 2014 02:17
@dhermesdhermes added api: datastore Issues related to the Datastore API. docs labels Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
* chore: use gapic-generator-python 0.58.4
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
* chore: use gapic-generator-python 0.58.4
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
* chore: use gapic-generator-python 0.58.4
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
* chore: use gapic-generator-python 0.58.4
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 427140868
Source-Link: googleapis/googleapis@0f56b69
Source-Link: googleapis/googleapis-gen@5239850
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTIzOTg1MGVkOWFiMzYxMjViY2U5MmIzODE1YWVmYjZmZWRlODk2YiJ9
feat: Add methods and messages related to business context feature docs: add autogenerated code snippets
parthea pushed a commit that referenced this pull request Jun 4, 2023
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 472772457
Source-Link: googleapis/googleapis@855b74d
Source-Link: googleapis/googleapis-gen@b64b1e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
parthea pushed a commit that referenced this pull request Jun 4, 2023
* feat: Add support for python 3.11
chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693
Source-Link: googleapis/googleapis@190b612
Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
* fix(deps): allow protobuf 3.19.5
* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Aug 15, 2023
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
parthea pushed a commit that referenced this pull request Sep 22, 2023
…297)
- [ ] Regenerate this pull request now.
docs: ReservationAffinity key field docs incorrect
docs: missing period in description for min CPU platform
PiperOrigin-RevId: 474706444
Source-Link: googleapis/googleapis@a5a8829
Source-Link: googleapis/googleapis-gen@992389d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTkyMzg5ZDgwOWVkMzdmOGZkNGQ3ODcyMDkwNDg1NTFkOWU2MTE1NCJ9
PiperOrigin-RevId: 474671838
Source-Link: googleapis/googleapis@9212f73
Source-Link: googleapis/googleapis-gen@37e2343
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzdlMjM0MzdmMmU4Nzc4Yjc1ZDAzNGQyOTQwMWY3NWNjYTk3NDkzYyJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/python-dlp/compare/v3.3.1...v3.4.0) (2021-12-03)
### Features
* added deidentify replacement dictionaries ([#296](https://www.github.com/googleapis/python-dlp/issues/296)) ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field for BigQuery inspect template inclusion lists ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field to support infotype versioning ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
)
Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.
fix: add 'dict' annotation type to 'request'
Committer: @busunkim96
PiperOrigin-RevId: 398509016
Source-Link: googleapis/googleapis@b224dfa
Source-Link: googleapis/googleapis-gen@63a1db7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Fix a minor typo
* chore(docs): Fix a minor typo
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 451250442
Source-Link: googleapis/googleapis@cca5e81
Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@c5026b3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* chore(deps): update dependency google-cloud-storage to v2.1.0
* set pin for google-cloud-storage for py36
* set pin for google-cloud-storage for py36
* revert pin for py36
* revert pin for py36
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* chore: exclude requirements.txt file from renovate-bot
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6
* update constraints files
* fix(deps): require protobuf 3.20.2
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@0941ef3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f90537dd7df70f6b663cd654b1fa5dee483cf6a4edcfd46072b2775be8a23ec
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
* chore: use gapic-generator-python 0.58.4
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
* chore: Update gapic-generator-python to v1.8.2
PiperOrigin-RevId: 504289125
Source-Link: googleapis/googleapis@38a48a4
Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* docs: Remove html formatting (cleanup)
PiperOrigin-RevId: 504326606
Source-Link: googleapis/googleapis@b7bb7fb
Source-Link: googleapis/googleapis-gen@cee916a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2VlOTE2YWVkYzllYjhmZGRkODQ0MzMxMzJjYWI1NzUyYTIwYzk4NSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.7.0...v2.8.0) (2021-09-10)
### Features
* add `BigQueryWriteClient` where `append_rows` returns a helper for writing rows ([#284](https://www.github.com/googleapis/python-bigquery-storage/issues/284)) ([2461f63](https://www.github.com/googleapis/python-bigquery-storage/commit/2461f63d37f707c2d634a95d87b8ffc3e4af3686))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 16, 2025
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.7.0...v2.8.0) (2021-09-10)
### Features
* add `BigQueryWriteClient` where `append_rows` returns a helper for writing rows ([#284](https://www.github.com/googleapis/python-bigquery-storage/issues/284)) ([2461f63](https://www.github.com/googleapis/python-bigquery-storage/commit/2461f63d37f707c2d634a95d87b8ffc3e4af3686))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@0ddbff8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* fix: handle bare 'grpc.Call' in 'from_grpc_error'
Fixes: #297.
* tests: add assertion for 'exception.details'
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
#297)
* fix: support correct numpy construction for dbjson dtype in pandas 1.5
* add unit tests for pandas 1.5
* nit
* fixing import error in python 3.7
* update unit tests
* nit
parthea pushed a commit that referenced this pull request Nov 24, 2025
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Holt Skinner <holtskinner@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* allow model properties as projection arguments in addition to names
* handle None and update tests
parthea pushed a commit that referenced this pull request Mar 2, 2026
* fix: use insecure gRPC channel with the emulator
* Regenerate the library
parthea pushed a commit that referenced this pull request Mar 2, 2026
This reverts commit e107a0cac7ca367015a025a6872a8ad28c7ff15c.
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DISCUSSION: Should dataset ID be set on datastore key?

3 participants

@tseaver@coveralls@dhermes