Skip to content

Cut release 1.0.0 of logging package. - #3278

Merged
lukesneeringer merged 2 commits into
masterfrom
cut-logging-1.0.0
Apr 7, 2017
Merged

Cut release 1.0.0 of logging package.#3278
lukesneeringer merged 2 commits into
masterfrom
cut-logging-1.0.0

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Should be OK after #3270? I made this branch on the GoogleCloudPlatform remote so that system tests are run in this PR.

@dhermesdhermes added api: logging Issues related to the Cloud Logging API. packaging labels Apr 6, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2017
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Error on Windows: https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.1430.master/job/ru59q79vnb23wxiu

any_pb == any_pb

will fail if the type is unregistered. This seems like a big FAIL of google.protobuf.

@lukesneeringer

Copy link
Copy Markdown
Contributor

Why on earth would that __eq__ not work only on Windows?

@lukesneeringer
lukesneeringer merged commit 7cf9051 into masterApr 7, 2017
@lukesneeringer
lukesneeringer deleted the cut-logging-1.0.0 branch April 7, 2017 01:43
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Looks like error-reporting==0.24.1 never got pushed. Will push a tag right now at 5878b78.

Only changes are this and #3299:

$ git log error-reporting-0.24.0..error-reporting-0.24.1 -- error_reporting/
commit 138f59fc1795e1e433822bdd62d927762fd8f2e2
Author: Bill Prin <waprin@gmail.com>
Date: Mon Apr 17 10:16:11 2017 -0700
Replace httpContext with httpRequest (#3299)
commit 7cf905115fbfa9d54850b6a3426f38ab7096009e
Author: Danny Hermes <daniel.j.hermes@gmail.com>
Date: Thu Apr 6 18:43:55 2017 -0700
Cut release 1.0.0 of logging package. (#3278)

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@lukesneeringer@tseaver@googlebot