Uh oh!
There was an error while loading. Please reload this page.
Replace httpContext with httpRequest - #3299
Merged
Merged
Conversation
dhermes
approved these changes
Apr 14, 2017
dhermes
left a comment
Contributor
There was a problem hiding this comment.
Tentative LGTM though you really should add some system tests
waprin
commented
Apr 17, 2017
ContributorAuthor
System test PR incoming sorry for delay but just want bug fix merged in meantime. |
This was referenced Apr 19, 2017
richkadel pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#2877 and probably fixes#3263 .
I will work on a followup system test since clearly needed.
NB: The reason for this bug and lack of system test is the pre-gRPC code went through Logging which was basically untyped, the errors were showing up despite the incorrect parameter names (and at the time without the full API there was no good way to system test).