Skip to content

Add basic system test for error reporting - #3336

Closed
waprin wants to merge 1 commit into
googleapis:masterfrom
waprin:error_system
Closed

Add basic system test for error reporting#3336
waprin wants to merge 1 commit into
googleapis:masterfrom
waprin:error_system

Conversation

@waprin

@waprinwaprin commented Apr 27, 2017•
edited by dhermes
Loading

Copy link
Copy Markdown
Contributor

This is the bare minimal system test that just makes a client call, it did go red before the scope fix at least.

Can add more asserts but need to add more code to authenticate a separate gax client to list errors, can add that to this PR or a new one.

Fixes#3335

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2017
@waprinwaprin changed the title Add basic system testAdd basic system test for error reportingApr 27, 2017
dhermes
dhermes reviewed Apr 27, 2017
View reviewed changes
Comment threaderror_reporting/nox.py
session.install('.')

# Run py.test against the system tests.
session.run('py.test', '-vvv', 'tests/system.py')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/nox.py

# Install all test dependencies, then install this package into the
# virtualenv's dist-packages.
session.install('.')

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/tests/system.py
try:
raise NameError
except NameError:
client.report_exception()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented May 2, 2017

Copy link
Copy Markdown
Contributor

Closing this in light of #3348

@dhermesdhermes closed this May 2, 2017
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96@leahecole
Update dependency google-cloud-pubsub to v1.4.2 [(#3336)](GoogleCloud…
fa301f3
…Platform/python-docs-samples#3336)
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dhermesdhermesdhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error reporting system tests needed

3 participants

@waprin@dhermes@googlebot