Add error reporting system test by waprin · Pull Request #3348 · googleapis/google-cloud-python

waprin · 2017-05-01T22:40:28Z

This actually uses the gapic client to verify counts.

It doesn't expose the gapic client outside of the system methods since unlikely they will need to be used (and we can wait on the general gapic doc improvements for those who do want it).

Fixes#3335.

Sign in to view

+
+ def setUp(self):
+ self._client = error_reporting.Client()
+ self._error_name = 'Stackdriver Error Reporting System Test'


Sign in to view

+ # exception, so first simulate it just to create the group
+ self._simulate_exception()
+
+ initial_count = self._get_error_count()


Sign in to view

+ return group.count
+
+ def test_report_exception(self):
+ """Verifies the exception reported increases the group count by one."""


Sign in to view

+from test_utils.retry import RetryResult
+
+
+class _ErrorStatsGaxApi(object):


Sign in to view

+ """
+ def __init__(self, project):
+ self._project = project
+ self._gax_api = error_stats_service_client.ErrorStatsServiceClient()


Sign in to view


 from google.cloud.gapic.errorreporting.v1beta1 import (
 report_errors_service_client)
+


Sign in to view


 # Install all test dependencies, then install this package into the
 # virtualenv's dist-packages.
+ session.install('flake8', *LOCAL_DEPS)


waprin · 2017-05-02T23:50:29Z

@dhermes still no hints as to why system tests are failing. I don't see the SSH option, wonder if you have any ideas why.

waprin · 2017-05-03T21:58:32Z

@dhermes mergeable?

Sign in to view

+ # If test has never run, group won't exist until we report first
+ # exception, so first simulate it just to create the group
+ self._simulate_exception()
+ time.sleep(2)


Sign in to view

+ except RuntimeError:
+ Config.CLIENT.report_exception()
+
+ def _get_error_count(self):


Sign in to view

+ :type project: str
+ :param project: Google Cloud Project ID
+ """
+ gax_api = error_stats_service_client.ErrorStatsServiceClient()


Sign in to view

+ project_name = gax_api.project_path(project)
+
+ time_range = error_stats_service_pb2.QueryTimeRange()
+ time_range.period = (


Sign in to view

+ )
+
+ duration = Duration()
+ duration.seconds = 60 * 60


Sign in to view

+ return gax_api.list_group_stats(
+ project_name, time_range, timed_count_duration=duration)
+
+ERROR_NAME = 'Stackdriver Error Reporting System Test'


Sign in to view

+
+class TestErrorReporting(unittest.TestCase):
+
+ def _simulate_exception(self):


Also adding a retry until the count comes back as expected.

googlebot · 2017-05-04T22:32:13Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

waprin · 2017-05-04T22:33:16Z

lgtm

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2017

dhermes mentioned this pull request May 2, 2017
Add basic system test for error reporting #3336
Closed

dhermes reviewed May 2, 2017
View reviewed changes

Comment threaderror_reporting/google/cloud/error_reporting/_gax.py Outdated

from google.cloud.gapic.errorreporting.v1beta1 import (
report_errors_service_client)

This comment was marked as spam.
Sign in to view

waprin force-pushed the error_system branch from c16971e to c9ec8ccCompare May 2, 2017 20:44

dhermes reviewed May 2, 2017
View reviewed changes

Comment threaderror_reporting/nox.py Outdated

# Install all test dependencies, then install this package into the
# virtualenv's dist-packages.
session.install('flake8', *LOCAL_DEPS)
This comment was marked as spam.
Sign in to view

dhermes reviewed May 3, 2017
View reviewed changes

Bill Prinand others added 8 commits May 4, 2017 12:41

Add error reporting system test
e7092d4

DHermes review
8d069c2

add local deps
9d9eee0

right test deps
2037fb3

fix test deps again
35fa463

dhermies review
ca2c440

fix test
a9c66c6

Using a unique class name for each stacktrace.
5cee9a8
Also adding a retry until the count comes back as expected.

dhermes force-pushed the error_system branch from 324f2f4 to 5cee9a8Compare May 4, 2017 22:32

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 4, 2017

dhermes merged commit 336a9f2 into masterMay 4, 2017

dhermes deleted the error_system branch May 4, 2017 22:41

tseaver mentioned this pull request Jun 26, 2017
Prep error-reporting-0.25.0 release. #3542
Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add error reporting system test (#3348)
d94a008

		from test_utils.retry import RetryResult


		class _ErrorStatsGaxApi(object):


		from google.cloud.gapic.errorreporting.v1beta1 import (
		report_errors_service_client)


		class TestErrorReporting(unittest.TestCase):

		def _simulate_exception(self):

Uh oh!

Conversation

waprin commented May 1, 2017• edited by dhermes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

waprin commented May 2, 2017

Uh oh!

waprin commented May 3, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented May 4, 2017

Uh oh!

waprin commented May 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

waprin commented May 1, 2017•
edited by dhermes
Loading