Annotate pylintrc w defaults and rationale by tseaver · Pull Request #368 · googleapis/google-cloud-python

tseaver · 2014-11-10T21:47:14Z

Generated from 'pylint --generate-rcfile'.

Defaults are commented out.

Exceptions to defaults include a rationale.

Note generation of 'pylintrc_reduced'.

Minor changes to code to conform w/ new config.

Helper, not API; unused outside 'gcloud.datastore.helpers'. Removes pylintrc wart.

Generated from 'pylint --generate-rcfile'. Defaults are commented out. Exceptions to defaults include a rationale. Note generation of 'pylintrc_reduced'.

tseaver · 2014-11-10T21:47:42Z

@dhermes, @silvolu PTAL.

Sign in to view

coveralls · 2014-11-10T21:56:04Z

Changes Unknown when pulling e9e69f9 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

Sign in to view

coveralls · 2014-11-10T22:14:20Z

Changes Unknown when pulling 5e0f5c3 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

coveralls · 2014-11-10T22:15:22Z

Changes Unknown when pulling 5e0f5c3 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-10T23:52:04Z

@dhermes any reason not to merge?

dhermes · 2014-11-11T01:39:56Z

Sorry, was in transit.

RE: YAGNI, I totally agree. However I've seen the unused_ prefix used a fair deal throughout large code-bases, but it's very possible we'll never have issue where we have to preserve an interface without requiring an argument.

In general, these were the kinds of discussions I wanted to have about the config so we can eliminate the churn.

@tseaver are we proposing this is the "frozen" final config or just a first step towards it?

tseaver · 2014-11-11T03:30:46Z

Given that I don't really believe in a "final" config, I'd say this is just a better config than what we have now: it drops some exclusions we no longer need, and documents the places where we adopt policies different than the out-of-the-box defaults. If we run up against future failures, it provides more information than we have now to decide whether to change the code or the pylintrc (by documenting all the defaults in place).

We could get to a "final" point for storage / datastore, and then still need to tweak it for either Py3k or a new API set (most of our explicit policies are due to API-mapping).

coveralls · 2014-11-11T14:18:24Z

Changes Unknown when pulling 1a79f4c on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-11T19:01:52Z

@dhermes OK to merge?

dhermes · 2014-11-11T22:07:21Z

LGTM

…_rationale Annotate pylintrc w defaults and rationale

* docs: Add documentation for latest models to RecognitionConfig PiperOrigin-RevId: 446200223 Source-Link: googleapis/googleapis@4f586ea Source-Link: googleapis/googleapis-gen@4ffe3d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZmZTNkOWZkZmYzY2M1NWRhNzBhNTZhOGM2NDM1ODdlMTZlMmZlOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* docs: update documentation to require certain fields PiperOrigin-RevId: 530345646 Source-Link: googleapis/googleapis@ae157a1 Source-Link: googleapis/googleapis-gen@1798b3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTc5OGIzZDBiZDE2YzZmZmM2YTFjY2EzMWYzMTYyOTQyMzQ3MjdiYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: integrate gapic-generator-python-1.4.1 and enable more py_test targets PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This comment is required to so that release-please updates the version. See https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: allow releases on previous majors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Add documentation for latest models to RecognitionConfig PiperOrigin-RevId: 446200223 Source-Link: googleapis/googleapis@4f586ea Source-Link: googleapis/googleapis-gen@4ffe3d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZmZTNkOWZkZmYzY2M1NWRhNzBhNTZhOGM2NDM1ODdlMTZlMmZlOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

Toward #368.

* feat: Support the Count aggregation query * Add `run_aggregation_query` interface to the http client. Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update all dependencies * Update docs.yml * Update lint.yml --------- Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>

#368) Source-Link: googleapis/synthtool@de3def6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: bulk writer 555 rate_limiter (#368) * added 555 throttle utility * Update google/cloud/firestore_v1/throttle.py Co-authored-by: Tres Seaver <tseaver@palladion.com> * added ability to request a number of tokens * replaced Callable now parameter with module function * updated tests * renamed throttle -> ramp up * improved docstrings * linting * fixed test coverage * rename to RateLimiter and defer clock to first op * linting Co-authored-by: Tres Seaver <tseaver@palladion.com> * feat: added new batch class for BulkWriter (#397) * feat: added new batch class for BulkWriter * updated docstring to use less colloquial language * feat: BulkWriter implementation (#384) * feat: added `write` method to batch classes * added docstrings to all 3 batch classes instead of just the base * updated batch classes to remove control flag now branches logic via subclasses * fixed broken tests off abstract class * fixed docstring * refactored BulkWriteBatch this commit increases the distance between WriteBatch and BulkWriteBatch * began adding [Async]BulkWriter * continued implementation * working impl or BW * tidied up BW impl * beginning of unit tests for BW * fixed merge problem * initial set of BW unit tests * refactored bulkwriter sending mechanism now consumes off the queue and schedules on the main thread, only going async to actually send * final CI touch ups * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * moved BulkWriter parameters to options format * rebased off master * test fixes Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add retry support for BulkWriter errors (#413) * parent 0176cc7fef8752433b5c2496046d3a56557eb824 author Craig Labenz <craig.labenz@gmail.com> 1623693904 -0700 committer Craig Labenz <craig.labenz@gmail.com> 1628617523 -0400 feat: add retries to bulk-writer * fixed rebase error Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

refs #367.

…lure' occurs (#368) * Add retry loop for fetching authentication token if any 'Internal failure' occurs This is to prevent errors while client tries to connect with server and fails with 'Internal Failure' because it was unable to fetch OAuth2 token. * Add retry loop for fetching authentication token if any 'Internal failure' occurs This is to prevent errors while client tries to connect with server and fails with 'Internal Failure' because it was unable to fetch OAuth2 token.

…cp/templates/python_library/.kokoro (#368) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

tseaver added 3 commits November 10, 2014 16:18

Avoid confusing pylint's 'missing-format-attribute'.
2ff5883

Rename '_get_protobuf_attribute_and_value'->'_pb_attr_value'.
982c51c
Helper, not API; unused outside 'gcloud.datastore.helpers'. Removes pylintrc wart.

Annotate base pylintrc.
e9e69f9
Generated from 'pylint --generate-rcfile'. Defaults are commented out. Exceptions to defaults include a rationale. Note generation of 'pylintrc_reduced'.

tseaver added the hygiene label Nov 10, 2014

This was referenced Nov 10, 2014
Move 'bucket.BucketIterator' -> 'connection._BucketIterator'. #358
Merged
Fix #26: expose bucket iterator w extra params #359
Merged
Fix #354: support slash in key names #364
Merged

dhermes reviewed Nov 10, 2014
View reviewed changes

Comment threadpylintrc_default Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 10, 2014
View reviewed changes

Comment threadpylintrc_default Outdated
This comment was marked as spam.
Sign in to view

tseaver added 2 commits November 10, 2014 17:00

US speling.
ecb5ded

Moar speling.
5e0f5c3

dhermes reviewed Nov 10, 2014
View reviewed changes

Comment threadpylintrc_default
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Update 'max-locals' as needed by#364.
1a79f4c

tseaver added a commit that referenced this pull request Nov 11, 2014
Merge pull request#368from tseaver/annotate_pylintrc_w_defaults_and…
95e80e1
…_rationale Annotate pylintrc w defaults and rationale

tseaver merged commit 95e80e1 into googleapis:masterNov 11, 2014

tseaver deleted the annotate_pylintrc_w_defaults_and_rationale branch November 11, 2014 22:09

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(deps): update dependency google-cloud-storage to v2.2.1 (#368)
b1a8ebb

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update all dependencies (#368)
3199bf0

parthea added a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency google-analytics-admin to v0.19.0 (#368)
df4cca8
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 0.17.0 (#368)
1224c5d
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 3.11.0 (#368)
b5a2a3b
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 21, 2025
chore: use python-samples-reviewers (#368)
8543d77

parthea pushed a commit that referenced this pull request Sep 16, 2025
chore: use python-samples-reviewers (#368)
e97d440

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 1.2.2 (#368)
fc40773
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: avoid aliasing known tables used in CTEs (#369)
5ed78f7
Toward #368.

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(deps): update dependency pytest to v8.4.1 (#368)
e8465e2
* chore(deps): update all dependencies * Update docs.yml * Update lint.yml --------- Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: added extra variables owlbot kokoro configs (#368)
8da8412

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: add missing _get_for_dict method (#368)
107cf4d
refs #367.

parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency mako to v1.2.4 (#368)
2a7eff2

parthea pushed a commit that referenced this pull request Mar 9, 2026
build: migrate to flakybot (#368)
7632eb0
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>

parthea added a commit that referenced this pull request Mar 9, 2026
fix(deps): add packaging requirement (#368)
e7ffc93

parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(main): release 3.2.0 (#368)
37e279b
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Uh oh!

Conversation

tseaver commented Nov 10, 2014

Uh oh!

tseaver commented Nov 10, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 10, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 10, 2014

Uh oh!

coveralls commented Nov 10, 2014

Uh oh!

tseaver commented Nov 10, 2014

Uh oh!

dhermes commented Nov 11, 2014

Uh oh!

tseaver commented Nov 11, 2014

Uh oh!

coveralls commented Nov 11, 2014

Uh oh!

tseaver commented Nov 11, 2014

Uh oh!

dhermes commented Nov 11, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants