Skip to content

Port gax helper methods - #4249

Merged
theacodes merged 4 commits into
googleapis:masterfrom
landrito:gax-apicore
Oct 25, 2017
Merged

Port gax helper methods#4249
theacodes merged 4 commits into
googleapis:masterfrom
landrito:gax-apicore

Conversation

@landrito

@landritolandrito commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
theacodes
theacodes reviewed Oct 24, 2017
View reviewed changes

@theacodestheacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, a few tiny nits. Thank you for doing this.

Comment threadapi_core/google/api_core/protobuf_helpers.py Outdated
"""Raise ValueError if more than one keyword argument is not none.
Args:
kwargs (dict): The keyword arguments sent to the function.
Returns: None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadapi_core/google/api_core/protobuf_helpers.py Outdated
"""
# Sanity check: If no keyword arguments were sent, this is fine.
if not kwargs:
return None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

theacodes
theacodes reviewed Oct 24, 2017
View reviewed changes
Comment threadapi_core/tests/unit/test_protobuf_helpers.py Outdated
assert protobuf_helpers.check_oneof(foo='bar') is None
assert protobuf_helpers.check_oneof(foo='bar', baz=None) is None
assert protobuf_helpers.check_oneof(foo=None, baz='bacon') is None
assert (protobuf_helpers.check_oneof(foo='bar', spam=None, eggs=None)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@landritolandrito mentioned this pull request Oct 24, 2017
Merged
5 tasks
@theacodes

theacodes commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

There's an unrelated lint error blocking this, I sent #4250 to fix. Can you verify that nox -s "unit_tests(python_version='3.6')" works locally? if so, I'm happy to merge this as-is without waiting to rebase.

@landrito

landrito commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

That command ran successfully.

@theacodes
theacodes merged commit 877ef4e into googleapis:masterOct 25, 2017
parthea pushed a commit that referenced this pull request Nov 24, 2025
@landritoJon Wayne Parrott
Port gax proto helper methods (#4249)
4c1827b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@theacodestheacodestheacodes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: corecla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@landrito@theacodes@googlebot