Skip to content

Fix bare except lint error - #4250

Merged
theacodes merged 1 commit into
googleapis:masterfrom
theacodes:fix-lint
Oct 24, 2017
Merged

Fix bare except lint error#4250
theacodes merged 1 commit into
googleapis:masterfrom
theacodes:fix-lint

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
@theacodestheacodes mentioned this pull request Oct 24, 2017

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though Pylint will also dislike this as over-broad

@theacodes

Copy link
Copy Markdown
ContributorAuthor

I turned off pylint.

@dhermes

Copy link
Copy Markdown
Contributor

I turned off pylint.

I know, I'm just pointing it out.

@theacodes
theacodes merged commit 54b3c98 into googleapis:masterOct 24, 2017
@theacodes
theacodes deleted the fix-lint branch October 24, 2017 22:54
parthea pushed a commit that referenced this pull request Oct 21, 2023
…latform/python-docs-samples#4251)
## Description
Fixes#4250
Note: It's a good idea to open an issue first for discussion.
## Checklist
- [x] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md)
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file)
- [x] **Tests** pass: `nox -s py-3.6` (see [Test Enviroment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [x] **Lint** pass: `nox -s lint` (see [Test Enviroment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
- [x] Please **merge** this PR for me once it is approved.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes@dhermes@googlebot