Uh oh!
There was an error while loading. Please reload this page.
Add spanner system tests: - #4371
Conversation
dhermes
left a comment
There was a problem hiding this comment.
LGTM, though that test case is getting pretty long. You should consider breaking it up.
tseaver
commented
Nov 9, 2017
@dhermes I split the "transfinite" cases out into a separate method. Code is otherwise unchanged: I will merge when Circle is green. |
- Bind timestamp. - Bind string array. - Bind empty string array. - Bind string to null. - Query returning array of -Inf, +Inf, NaN.
Group all -inf / +inf / nan cases together.
ce26b03 to
03304c9Comparetseaver
commented
Nov 9, 2017
Rebased to pick up hardening from merged #4374. |
chemelnucfin
left a comment
There was a problem hiding this comment.
LGTM. But agree with @dhermes comment about too many checks in one method. No big deal though.
Also, may I suggest to use origin (your own) for branching instead of upstream (gcp) to keep branches tidy?
dhermes
commented
Nov 9, 2017
This was intentional by @tseaver. When we push to the upstream remote, the system tests get run (they get skipped on PR builds otherwise). But good advice otherwise! |
chemelnucfin
commented
Nov 9, 2017
@dhermes wait, so if I make a PR the system tests don't run on CI? |
dhermes
commented
Nov 9, 2017
@chemelnucfin That's correct. It's a security concern, since anyone can send a PR. Check out one of your builds, it'll say "skipped" by the system tests. |
- Bind timestamp. - Bind string array. - Bind empty string array. - Bind string to null. - Query returning array of -Inf, +Inf, NaN.
Toward #4364.