Uh oh!
There was an error while loading. Please reload this page.
Harden spanner system tests against stray databases - #4374
Merged
Conversation
dhermes
reviewed
Nov 9, 2017
| self.assertEqual(found, expected) | ||
| database_ids = [ | ||
| database.database_id | ||
| for database in Config.INSTANCE.list_databases()] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Because of quota, we are sharing the instance we use to test CRUD of databases: we therefore cannot rely on having only the expected databases present, as other tests may be running simultaneously, or may have failed in ways which left 'stray' databases in the instance.
tseaverforce-pushed
the
spanner-system-tests-stray-dbs
branch
from
November 9, 2017 20:53
066d8a5 to
8f20130Comparetseaver
commented
Nov 9, 2017
ContributorAuthor
#4377 is blocking the run. The system tests pass locally. |
This was referenced Nov 9, 2017
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
Because of quota, we are sharing the instance we use to test CRUD of databases: we therefore cannot rely on having only the expected databases present, as other tests may be running simultaneously, or may have failed in ways which left 'stray' databases in the instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of quota, we are sharing the instance we use to test CRUD of databases: we therefore cannot rely on having only the expected databases present, as other tests may be running simultaneously, or may have failed
in ways which left 'stray' databases in the instance.