Skip to content

Revert "api_core: Make PageIterator.item_to_value public. (#4702)" - #4731

Merged
theacodes merged 2 commits into
masterfrom
revert-4702
Jan 11, 2018
Merged

Revert "api_core: Make PageIterator.item_to_value public. (#4702)"#4731
theacodes merged 2 commits into
masterfrom
revert-4702

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

This reverts commit 813a27e.

This is done to prevent a release-the-world scenario in order to release bigquery, spanner, and datastore. It will be re-reverted before the next minor release of api_core.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2018
@dhermes

Copy link
Copy Markdown
Contributor

@jonparrott This is just a straight git revert. You also need to update spanner/google/cloud/spanner_v1/client.py and spanner/google/cloud/spanner_v1/instance.py:

$ git log -1 --pretty=%H
d2ff0b9a68b55dff09b905736df7ddaaf722ce95
$ git grep -l '\.item_to_value'
api_core/google/api_core/page_iterator.py
api_core/tests/unit/test_page_iterator.py
bigquery/tests/unit/test_table.py
datastore/google/cloud/datastore/query.py
spanner/google/cloud/spanner_v1/client.py
spanner/google/cloud/spanner_v1/instance.py

@theacodes

Copy link
Copy Markdown
ContributorAuthor

@dhermes good call.

@theacodestheacodes mentioned this pull request Jan 10, 2018
@dhermes

Copy link
Copy Markdown
Contributor

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes@dhermes@googlebot