Skip to content

Revert "Revert "api_core: Make PageIterator.item_to_value public. (#4702)"" - #4734

Merged
theacodes merged 3 commits into
masterfrom
revert-4731-revert-4702
Feb 27, 2018
Merged

Revert "Revert "api_core: Make PageIterator.item_to_value public. (#4702)""#4734
theacodes merged 3 commits into
masterfrom
revert-4731-revert-4702

Conversation

@theacodes

@theacodestheacodes commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

Reverts #4731

inception-meme

Do not merge until api_core 0.2.0 is being prepped for release.

Context:

This is done to prevent a release-the-world scenario in order to release bigquery, spanner, and datastore. It will be re-reverted before the next minor release of api_core.

@theacodestheacodes added packaging do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: core labels Jan 11, 2018
@theacodestheacodes self-assigned this Jan 11, 2018
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
@dhermes

dhermes commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

@jonparrott After #4750 goes in (and this gets rebased on top of it) I'd like to add another commit to make sure that datastore and spanner depend on google-api-core >= 0.1.5.dev1 (I'm on the fence on whether BigQuery should depend on this version, since it's a test-only change).

UPDATE: Merged #4750 and sent the commit.

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 12, 2018
@chemelnucfinchemelnucfin added the type: process A process-related concern. May include testing, release, or the like. label Jan 15, 2018
@theacodes
theacodesforce-pushed the revert-4731-revert-4702 branch from b1e3902 to 8ca6c49CompareFebruary 26, 2018 21:12
@theacodestheacodes removed cla: no This human has *not* signed the Contributor License Agreement. do not close do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 26, 2018
@theacodes

Copy link
Copy Markdown
ContributorAuthor

I have added an alias property for the private method. This allows us to maintain compatibility even for some older clients. We can remove it at a later date.

I will merge this once CI is green.

@theacodes
theacodesforce-pushed the revert-4731-revert-4702 branch from 8ca6c49 to 8ee15aaCompareFebruary 26, 2018 21:18
Jon Wayne Parrott added 2 commits February 26, 2018 14:27
Additionally add backwards-compatible shim for private _item_to_value
@theacodes
theacodesforce-pushed the revert-4731-revert-4702 branch from 8ee15aa to 7933276CompareFebruary 26, 2018 22:27
@theacodes

Copy link
Copy Markdown
ContributorAuthor

nvm, I'm going to release the world anyway, I'm gonna remove the alias.

@theacodes
theacodes merged commit 53c6d89 into masterFeb 27, 2018
@theacodes
theacodes deleted the revert-4731-revert-4702 branch February 27, 2018 18:50
@theacodestheacodes mentioned this pull request Feb 27, 2018
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: corepackagingtype: processA process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@theacodes@dhermes@googlebot@chemelnucfin