Skip to content

Derive 'Transaction' from 'Batch'. - #516

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:derive_transaction_from_batch
Jan 8, 2015
Merged

Derive 'Transaction' from 'Batch'.#516
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:derive_transaction_from_batch

Conversation

@tseaver

@tseavertseaver commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

As a side effect, Transaction gets put and delete methods.

dhermes
dhermes reviewed Jan 8, 2015
View reviewed changes
Comment threadgcloud/datastore/transaction.py

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

FYI #514 is an attempt to break down our discussion.

This LGTM pending Travis. I have a feeling lint will complain about not calling super() in __enter__ and __exit__ but maybe not.

@coveralls

coveralls commented Jan 8, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 7cb31f7 on tseaver:derive_transaction_from_batch into 2b4f52f on GoogleCloudPlatform:master.

@dhermes

dhermes commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

Yay lint didn't care! Probably because signature remained the same.

tseaver added a commit that referenced this pull request Jan 8, 2015
@tseaver
Merge pull request#516from tseaver/derive_transaction_from_batch
77cfe10
Derive 'Transaction' from 'Batch'.
@tseaver
tseaver merged commit 77cfe10 into googleapis:masterJan 8, 2015
@tseaver
tseaver deleted the derive_transaction_from_batch branch January 8, 2015 19:59
@dhermesdhermes mentioned this pull request Jan 8, 2015
Closed
8 tasks
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#516)
f8c203e
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore: [autoapprove] update readme_gen.py to include autoescape True (#…
452fcdf
…516)
Source-Link: googleapis/synthtool@6b4d5a6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#516)
bac21ac
* chore: Update gapic-generator-python to v1.8.4
PiperOrigin-RevId: 507808936
Source-Link: googleapis/googleapis@64cf849
Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#516)
46099a0
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot@parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#516)
3961754
* chore: update to gapic-generator-python 1.5.0
feat: add support for `google.cloud.<api>.__version__`
PiperOrigin-RevId: 484665853
Source-Link: googleapis/googleapis@8eb249a
Source-Link: googleapis/googleapis-gen@c8aa327
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update version in gapic_version.py
* add .release-please-manifest.json with correct version
* set manifest to true in .github/release-please.yml
* add release-please-config.json
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: Update to gapic-generator-python 1.6.0
feat(python): Add typing to proto.Message based class attributes
feat(python): Snippetgen handling of repeated enum field
PiperOrigin-RevId: 487326846
Source-Link: googleapis/googleapis@da380c7
Source-Link: googleapis/googleapis-gen@61ef576
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* feat: new APIs added to reflect updates to the filestore service
- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled
PiperOrigin-RevId: 487492758
Source-Link: googleapis/googleapis@5be5981
Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update path to snippet metadata json
* chore: Update gapic-generator-python to v1.6.1
PiperOrigin-RevId: 488036204
Source-Link: googleapis/googleapis@08f275f
Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* docs: Small change for documentation
PiperOrigin-RevId: 490109215
Source-Link: googleapis/googleapis@0cbcc59
Source-Link: googleapis/googleapis-gen@6c019fa
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmMwMTlmYTE1NzU0YmJlZGZiMGRjZmNiY2RjOTdhODVkMzhjZjE5ZCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* docs: Small change for documentation
PiperOrigin-RevId: 490314741
Source-Link: googleapis/googleapis@9247e23
Source-Link: googleapis/googleapis-gen@40eb7b3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDBlYjdiMzM1Mzk1NThkYjUwMmM4YmQ4M2YyMDYyYjk4NmY4YTljNSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* add gapic_version.py
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0
fix: Drop usage of pkg_resources
fix: Fix timeout default values
docs(samples): Snippetgen should call await on the operation coroutine before calling result
PiperOrigin-RevId: 493260409
Source-Link: googleapis/googleapis@fea4387
Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* add gapic_version.py
* use templated owlbot.py and setup.py
* configure release please to use manifest
* restore testing/constraints-3.7.txt
* update version in gapic_version.py
* remove obsolete entries in release please config
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/g…
32d5484
…cp/templates/python_library/.kokoro (#516)
Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#516)
d13d218
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea pushed a commit that referenced this pull request Nov 22, 2025
@renovate-bot
chore(deps): update dependency google-cloud-bigtable to v2.5.2 (#516)
b4cf56e
parthea added a commit that referenced this pull request Nov 24, 2025
@bricker@parthea
fix: incorrect return type annotation for Message.to_dict (#516)
f50516e
The `proto.Message.to_dict` function returns a `dict[str, Any]`, but its
return type annotation is incorrectly set to `Message`.
The `proto.Message.to_dict` function returns the result of calling
[`google.protobuf.json_format.MessageToDict()`](https://github.com/protocolbuffers/protobuf/blob/c58621b6ff2e6145ffb14c7e5a7af7648dfc0535/python/google/protobuf/json_format.py#L125-L162),
which returns `dict[str, Any]` as specified in the [protobuf typeshed
stubs](https://github.com/python/typeshed/blob/main/stubs/protobuf/google/protobuf/json_format.pyi#L23-L30).
Additionally, runtime introspection shows that the function returns a
`dict`.
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@daniel-sanche@gcf-owl-bot
chore: Update CODEOWNERS (#516)
ad9af50
* chore: Update CODEOWNERS
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): use python 3.10 for docs build (#516)
ecdaf15
Source-Link: googleapis/synthtool@9ae0785
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 2.4.0 (#516)
49d7d1f
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): add E231 to .flake8 ignore list (#516)
c6f62bb
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Nov 24, 2025
Chris Rossi
perf: improve count query performance for simple queries (#516)
3d7595a
For simple queries (queries that map directly to single Datastore
queries, ie not multiqueries, or queries with post filters),
`Query.count` can be otimized by setting a high offset and counting the
number of entities skipped.
Note that this still requires Datastore to assemble and iterate over a
result set and Datastore will still only "skip" a certain number of
entities at a time. (1000 at the time of this writing.) So this doesn't
dramatically impact the amount of work that has to be done on the
Datastore side, nor does it reduce the number gRPC calls necessary to
count a large result set. It does reduce significantly, however, the amount of
I/O required, which has sped up some large counts in testing by a factor
of around 4x.
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gcf-owl-bot
chore(python): add E231 to .flake8 ignore list (#516)
a3698ec
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Nov 26, 2025
@arithmetic1728
fix: fix impersonated cred for gcloud (#516)
0e1ab39
* fix: fix impersonated cred for gcloud
(1) For IDTokenCredentials.refresh(self.request), use the provided request instead of creating a new one
(2) For Credentials, only refresh the source credentials if it is not valid
* update expired func
parthea pushed a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot
feat: add context manager support in client (#516)
b8d184d
- [ ] Regenerate this pull request now.
chore: fix docstring for first attribute of protos
committer: @busunkim96
PiperOrigin-RevId: 401271153
Source-Link: googleapis/googleapis@787f8c9
Source-Link: googleapis/googleapis-gen@81decff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9
parthea pushed a commit that referenced this pull request Mar 2, 2026
@release-please
chore: release 2.9.0 (#522)
5ebed69
🤖 I have created a release \*beep\* \*boop\*
---
## [2.9.0](https://www.github.com/googleapis/python-pubsub/compare/v2.8.0...v2.9.0) (2021-11-10)
### Features
* add context manager support in client ([#516](https://www.github.com/googleapis/python-pubsub/issues/516)) ([51eae67](https://www.github.com/googleapis/python-pubsub/commit/51eae67c47e2ce7d2f7620209e98df4a129801b5))
* add support for Python 3.10 ([#518](https://www.github.com/googleapis/python-pubsub/issues/518)) ([bb25d75](https://www.github.com/googleapis/python-pubsub/commit/bb25d755d70ba19e69d8a281be65f13eb994967d))
### Bug Fixes
* add 'dict' annotation type to 'request' ([b72522a](https://www.github.com/googleapis/python-pubsub/commit/b72522a4617c4b2773fb6a5a631038791aa08300))
* **deps:** drop packaging dependency ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* **deps:** require google-api-core >= 1.28.0 ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* improper types in pagers generation ([2ad639d](https://www.github.com/googleapis/python-pubsub/commit/2ad639d6370c7a085498595d7bd0d7eaadfff3c1))
### Documentation
* add type annotations to codebase ([#509](https://www.github.com/googleapis/python-pubsub/issues/509)) ([093cabf](https://www.github.com/googleapis/python-pubsub/commit/093cabff9f0464b1dfaa8f373b6fffbc439518de))
* list oneofs in docstring ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Mar 6, 2026
Ilya Gurov
feat: Add dummy WHERE clause to certain statements (#516)
5aa4fdb
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency grpcio to v1.68.0 (#516)
1a756ec
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
tests: split systests out into separate Kokoro jobs (#516)
97241cf
Closes#515
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastoreIssues related to the Datastore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@coveralls